Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2688513005: cros: Open play store app for md-settings stylus "Find more apps" link (Closed)

Created:
3 years, 10 months ago by jdufault
Modified:
3 years, 10 months ago
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Open play store app for md-settings stylus "Find more apps" link BUG=b/34682082 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2688513005 Cr-Commit-Position: refs/heads/master@{#449716} Committed: https://chromium.googlesource.com/chromium/src/+/a49b234976b50f7d9c50b753161d17bd1126b644

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -2 lines) Patch
M chrome/browser/resources/settings/device_page/device_page_browser_proxy.js View 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/device_page/stylus.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/device_page/stylus.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/chromeos/device_stylus_handler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/chromeos/device_stylus_handler.cc View 3 chunks +17 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 20 (13 generated)
jdufault
stevenjb@, djacobo@, PTAL. Thanks!
3 years, 10 months ago (2017-02-10 02:24:49 UTC) #8
stevenjb (google-dont-use)
lgtm
3 years, 10 months ago (2017-02-10 02:29:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2688513005/1
3 years, 10 months ago (2017-02-10 02:33:56 UTC) #12
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-02-10 02:33:58 UTC) #14
stevenjb
On 2017/02/10 02:33:58, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
3 years, 10 months ago (2017-02-10 20:06:25 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2688513005/1
3 years, 10 months ago (2017-02-10 20:07:37 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 20:18:30 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a49b234976b50f7d9c50b753161d...

Powered by Google App Engine
This is Rietveld 408576698