Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Issue 2682413002: cros: Fix crash when enabling arc in md-settings. (Closed)

Created:
3 years, 10 months ago by jdufault
Modified:
3 years, 10 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Fix crash when enabling arc in md-settings. StylusHandler tried to run a JavaScript callback without explicitly allowing it beforehand. BUG=690326, 690637 Review-Url: https://codereview.chromium.org/2682413002 Cr-Commit-Position: refs/heads/master@{#449468} Committed: https://chromium.googlesource.com/chromium/src/+/cf22397e17104d6b16cad0f93be089d5857005a5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/ui/webui/settings/chromeos/device_stylus_handler.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (9 generated)
jdufault
stevenjb@ PTAL. Thanks!
3 years, 10 months ago (2017-02-09 23:29:03 UTC) #7
stevenjb
lgtm
3 years, 10 months ago (2017-02-09 23:31:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2682413002/1
3 years, 10 months ago (2017-02-09 23:32:56 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 23:49:33 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cf22397e17104d6b16cad0f93be0...

Powered by Google App Engine
This is Rietveld 408576698