Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Issue 2688483004: [build] Enable gn build for vtune support in v8. (Closed)

Created:
3 years, 10 months ago by chunyang.dai
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[build] Enable gn build for vtune support in v8. BUG= Review-Url: https://codereview.chromium.org/2688483004 Cr-Commit-Position: refs/heads/master@{#43133} Committed: https://chromium.googlesource.com/v8/v8/+/e5168c79295c85af4235e9c88a427cbaded43267

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -2 lines) Patch
M BUILD.gn View 4 chunks +10 lines, -2 lines 0 comments Download
A src/third_party/vtune/BUILD.gn View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
chunyang.dai
Hi, Danno & Jochen: PTAL. thanks
3 years, 10 months ago (2017-02-09 16:14:43 UTC) #7
jochen (gone - plz use gerrit)
lgtm
3 years, 10 months ago (2017-02-10 09:05:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2688483004/1
3 years, 10 months ago (2017-02-13 02:52:28 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 02:54:13 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/e5168c79295c85af4235e9c88a427cbaded...

Powered by Google App Engine
This is Rietveld 408576698