Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: BUILD.gn

Issue 2688483004: [build] Enable gn build for vtune support in v8. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/third_party/vtune/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 3d7f0a7badf91632f2c9e127cf2798b692656876..5f85c31f8bff21664d238f72289cb58bde8fb582 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -41,6 +41,9 @@ declare_args() {
# Sets -dENABLE_GDB_JIT_INTERFACE.
v8_enable_gdbjit = ""
+ # Sets -dENABLE_VTUNE_JIT_INTERFACE.
+ v8_enable_vtunejit = false
+
# Sets -dENABLE_HANDLE_ZAPPING.
v8_enable_handle_zapping = true
@@ -197,6 +200,9 @@ config("features") {
if (v8_enable_gdbjit) {
defines += [ "ENABLE_GDB_JIT_INTERFACE" ]
}
+ if (v8_enable_vtunejit) {
+ defines += [ "ENABLE_VTUNE_JIT_INTERFACE" ]
+ }
if (v8_enable_object_print) {
defines += [ "OBJECT_PRINT" ]
}
@@ -2638,8 +2644,6 @@ v8_executable("d8") {
"//build/win:default_exe_manifest",
]
- # TODO(jochen): Add support for vtunejit.
-
if (is_posix) {
sources += [ "src/d8-posix.cc" ]
} else if (is_win) {
@@ -2658,6 +2662,10 @@ v8_executable("d8") {
if (v8_enable_inspector) {
defines += [ "V8_INSPECTOR_ENABLED" ]
}
+
+ if (v8_enable_vtunejit) {
+ deps += [ "//src/third_party/vtune:v8_vtune" ]
+ }
}
v8_isolate_run("d8") {
« no previous file with comments | « no previous file | src/third_party/vtune/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698