Chromium Code Reviews Chromium Code Reviews
Issue
2688413014:
Reland of actor History's CommitLaterTask with CancelableCallback (Closed)
DescriptionReland of actor History's CommitLaterTask with CancelableCallback (patchset #1 id:1 of https://codereview.chromium.org/2697513002/ )
Reason for revert:
Surfaced use-after free preceded the CL and has been fixed since by https://codereview.chromium.org/2690993002
Original issue's description:
> Revert of Refactor History's CommitLaterTask with CancelableCallback (patchset #7 id:120001 of https://codereview.chromium.org/2672753002/ )
>
> Reason for revert:
> Suspect for introducing the memory leak in ~TypedUrlSyncableServiceTest_DeleteUrlAndVisits().
>
> For more details, please see:
> https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/19518/steps/components_unittests/logs/TypedUrlSyncableServiceTest.DeleteUrlAndVisits
>
> Original issue's description:
> > Refactor History's CommitLaterTask with CancelableCallback
> >
> > Addresses an old TODO to replace the class with CancelableCallback,
> > which is almost a drop-in replacement.
> >
> > base::Unretained(this) is used for the callback because there should be,
> > according to the DCHECK in the destructor, no scheduled commit during
> > destruction.
> >
> > Review-Url: https://codereview.chromium.org/2672753002
> > Cr-Commit-Position: refs/heads/master@{#449735}
> > Committed: https://chromium.googlesource.com/chromium/src/+/87585300304e2a813e13b18c3fca1022c167bf91
>
> TBR=treib@chromium.org,brettw@chromium.org,gangwu@chromium.org,mastiz@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
>
> Review-Url: https://codereview.chromium.org/2697513002
> Cr-Commit-Position: refs/heads/master@{#449925}
> Committed: https://chromium.googlesource.com/chromium/src/+/2912ffa778a102b9cade9a99eadbe8757c66bb8a
TBR=treib@chromium.org,brettw@chromium.org,gangwu@chromium.org,msramek@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
Review-Url: https://codereview.chromium.org/2688413014
Cr-Commit-Position: refs/heads/master@{#450931}
Committed: https://chromium.googlesource.com/chromium/src/+/2cab568cb8a0930e5b705e1ee82e466913cb682f
Patch Set 1 #
Messages
Total messages: 10 (7 generated)
|
|||||||||||||||||||||||||||||||||||||
