Revert of Refactor History's CommitLaterTask with CancelableCallback

Revert of Refactor History's CommitLaterTask with CancelableCallback (patchset #7 id:120001 of https://codereview.chromium.org/2672753002/ )

Reason for revert:
Suspect for introducing the memory leak in ~TypedUrlSyncableServiceTest_DeleteUrlAndVisits().

For more details, please see:
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/19518/steps/components_unittests/logs/TypedUrlSyncableServiceTest.DeleteUrlAndVisits

Original issue's description:
> Refactor History's CommitLaterTask with CancelableCallback
> 
> Addresses an old TODO to replace the class with CancelableCallback,
> which is almost a drop-in replacement.
> 
> base::Unretained(this) is used for the callback because there should be,
> according to the DCHECK in the destructor, no scheduled commit during
> destruction.
> 
> Review-Url: https://codereview.chromium.org/2672753002
> Cr-Commit-Position: refs/heads/master@{#449735}
> Committed: https://chromium.googlesource.com/chromium/src/+/87585300304e2a813e13b18c3fca1022c167bf91

TBR=treib@chromium.org,brettw@chromium.org,gangwu@chromium.org,mastiz@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.

Review-Url: https://codereview.chromium.org/2697513002
Cr-Commit-Position: refs/heads/master@{#449925}
Committed: https://chromium.googlesource.com/chromium/src/+/2912ffa778a102b9cade9a99eadbe8757c66bb8a

[msramek, 2017-02-13 09:43:58]

The CQ bit was checked by msramek@chromium.org

[msramek, 2017-02-13 09:43:58]

Created Revert of Refactor History's CommitLaterTask with CancelableCallback

[commit-bot: I haz the power, 2017-02-13 09:44:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 10:33:58]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486979038269800, "parent_rev":
"54a9003370b8de1e2f968d524f02237207c720d0", "commit_rev":
"2912ffa778a102b9cade9a99eadbe8757c66bb8a"}

[commit-bot: I haz the power, 2017-02-13 10:34:28]

Description was changed from

==========
Revert of Refactor History's CommitLaterTask with CancelableCallback (patchset
#7 id:120001 of https://codereview.chromium.org/2672753002/ )

Reason for revert:
Suspect for introducing the memory leak in
~TypedUrlSyncableServiceTest_DeleteUrlAndVisits().

For more details, please see:
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chrom...

Original issue's description:
> Refactor History's CommitLaterTask with CancelableCallback
> 
> Addresses an old TODO to replace the class with CancelableCallback,
> which is almost a drop-in replacement.
> 
> base::Unretained(this) is used for the callback because there should be,
> according to the DCHECK in the destructor, no scheduled commit during
> destruction.
> 
> Review-Url: https://codereview.chromium.org/2672753002
> Cr-Commit-Position: refs/heads/master@{#449735}
> Committed:
https://chromium.googlesource.com/chromium/src/+/87585300304e2a813e13b18c3fca...

TBR=treib@chromium.org,brettw@chromium.org,gangwu@chromium.org,mastiz@chromiu...
# Not skipping CQ checks because original CL landed more than 1 days ago.
==========

to

==========
Revert of Refactor History's CommitLaterTask with CancelableCallback (patchset
#7 id:120001 of https://codereview.chromium.org/2672753002/ )

Reason for revert:
Suspect for introducing the memory leak in
~TypedUrlSyncableServiceTest_DeleteUrlAndVisits().

For more details, please see:
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chrom...

Original issue's description:
> Refactor History's CommitLaterTask with CancelableCallback
> 
> Addresses an old TODO to replace the class with CancelableCallback,
> which is almost a drop-in replacement.
> 
> base::Unretained(this) is used for the callback because there should be,
> according to the DCHECK in the destructor, no scheduled commit during
> destruction.
> 
> Review-Url: https://codereview.chromium.org/2672753002
> Cr-Commit-Position: refs/heads/master@{#449735}
> Committed:
https://chromium.googlesource.com/chromium/src/+/87585300304e2a813e13b18c3fca...

TBR=treib@chromium.org,brettw@chromium.org,gangwu@chromium.org,mastiz@chromiu...
# Not skipping CQ checks because original CL landed more than 1 days ago.

Review-Url: https://codereview.chromium.org/2697513002
Cr-Commit-Position: refs/heads/master@{#449925}
Committed:
https://chromium.googlesource.com/chromium/src/+/2912ffa778a102b9cade9a99eadb...
==========

[commit-bot: I haz the power, 2017-02-13 10:34:28]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2912ffa778a102b9cade9a99eadb...

[mastiz, 2017-02-16 09:54:44]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2688413014/ by mastiz@chromium.org.

The reason for reverting is: Surfaced use-after free preceded the CL and has
been fixed since by https://codereview.chromium.org/2690993002.