Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 2688413005: Check paint offset change after updatePaintOffsetTransform (Closed)

Created:
3 years, 10 months ago by Xianzhu
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, blink-reviews-layout_chromium.org, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, dshwang, jchaffraix+rendering, blink-reviews-paint_chromium.org, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check paint offset change after updatePaintOffsetTransform LayoutObject::paintOffset() is the paint offset after paintOffsetTransform. We should compare the paint offset tree builder context after updatePaintOffsetTransform. Previously we had false-positives of paint offset change, causing unnecessary whole subtree paint property updates. BUG=685179 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -17 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 chunk +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp View 3 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (6 generated)
Xianzhu
Description was changed from ========== Check paint offset change after updatePaintOffsetTransform BUG=685179 ========== to ========== ...
3 years, 10 months ago (2017-02-14 01:32:29 UTC) #1
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run
3 years, 10 months ago (2017-02-14 01:32:34 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2688413005/1
3 years, 10 months ago (2017-02-14 01:38:48 UTC) #3
Xianzhu
Description was changed from ========== Check paint offset change after updatePaintOffsetTransform BUG=685179 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ...
3 years, 10 months ago (2017-02-14 01:41:53 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-14 03:16:21 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 03:16:22 UTC) #6
Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698