Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(803)

Unified Diff: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp

Issue 2688413005: Check paint offset change after updatePaintOffsetTransform (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
index 445c595b44494fdbe577d5a7e7666be82f5e91ef..c06d8c0d544281d1624a6a0a227ebb9e544c9e27 100644
--- a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
@@ -929,11 +929,6 @@ void PaintPropertyTreeBuilder::updateContextForBoxPosition(
-toLayoutBox(parentRow)->physicalLocation());
}
}
-
- // Many paint properties depend on paint offset so we force an update of
- // the entire subtree on paint offset changes.
- if (object.paintOffset() != context.current.paintOffset)
- context.forceSubtreeUpdate = true;
}
void PaintPropertyTreeBuilder::updatePropertiesForSelf(
@@ -943,6 +938,8 @@ void PaintPropertyTreeBuilder::updatePropertiesForSelf(
FindObjectPropertiesNeedingUpdateScope checkNeedsUpdateScope(object, context);
#endif
+ updateContextForBoxPosition(object, context);
+
if (object.isBoxModelObject() || object.isSVG()) {
updatePaintOffsetTranslation(object, context);
updateTransform(object, context);
@@ -954,9 +951,12 @@ void PaintPropertyTreeBuilder::updatePropertiesForSelf(
updateScrollbarPaintOffset(object, context);
}
- if (object.needsPaintPropertyUpdate() || context.forceSubtreeUpdate) {
- if (RuntimeEnabledFeatures::slimmingPaintV2Enabled() &&
- object.paintOffset() != context.current.paintOffset) {
+ if (object.paintOffset() != context.current.paintOffset) {
+ // Many paint properties depend on paint offset so we force an update of
+ // the entire subtree on paint offset changes.
+ context.forceSubtreeUpdate = true;
+
+ if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
object.getMutableForPainting().setShouldDoFullPaintInvalidation(
PaintInvalidationLocationChange);
}
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutObject.h ('k') | third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698