Fix TypeError message for Reflect.construct

Fix TypeError message for Reflect.construct

If the Reflect.construct receives an argument expected to be a constructor,
and the argument is not a constructor, V8 currently declares that
Reflect.construct is not a function. It should instead say that the offending
argument is not a constructor.

This is the case for all ports of builtins
(Builtins::Generate_ReflectConstruct). All of them make an
attempt to at least pass the right argument to the TypeError parametrised
message, calling out the offending Reflect.construct argument. However,
Runtime::kThrowCalledNonCallable extracts the callsite from those arguments,
discarding the precise information.

This CL adds Runtime::kNotConstructor, which reports the arguments passed
to it, and the CL also modifies the ports of builtins to make use of
Runtime::kNotConstructor

BUG=v8:5671
Review-Url: https://codereview.chromium.org/2688393003
Cr-Commit-Position: refs/heads/master@{#43182}
Committed: https://chromium.googlesource.com/v8/v8/+/b478e9c11c3b01e4b34607182bab4774334f0e4d

[vabr (Chromium), 2017-02-12 21:37:01]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-12 21:37:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-12 22:07:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-12 22:07:29]

Dry run: Try jobs failed on following builders:
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_arm_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng_trigger...)

[vabr (Chromium), 2017-02-12 22:15:50]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-12 22:16:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2017-02-12 22:19:38]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-12 22:19:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2017-02-12 22:21:26]

Description was changed from

==========
Fix TypeError message for Reflect.construct

If the Reflect.construct receives an argument expected to be a constructor,
and the argument is not a constructor, V8 currently declares that
Reflect.construct is not a function. It should instead say that the offending
argument is not a constructor.

This is the case for all ports of builtins
(Builtins::Generate_ReflectConstruct). Some of them (e.g., x64), make an
attempt to at least pass the right argument to the TypeError parametrised
message, calling out the offending Reflect.construct argument. Others do not
(e.g., arm). In both cases this ends up the same, calling out the callsite
(Reflect.construct) instead, due to being handled by
Runtime::kThrowCalledNonCallable.

This CL adds Runtime::kNotConstructor and modifies the ports of builtins to
make use of it.

BUG=v8:5671
==========

to

==========
Fix TypeError message for Reflect.construct

If the Reflect.construct receives an argument expected to be a constructor,
and the argument is not a constructor, V8 currently declares that
Reflect.construct is not a function. It should instead say that the offending
argument is not a constructor.

This is the case for all ports of builtins
(Builtins::Generate_ReflectConstruct). All of them make an
attempt to at least pass the right argument to the TypeError parametrised
message, calling out the offending Reflect.construct argument. However,
Runtime::kThrowCalledNonCallable extracts the callsite from those arguments,
discarding the precise information.

This CL adds Runtime::kNotConstructor, which reports the arguments passed
to it, and the CL also modifies the ports of builtins to make use of
Runtime::kNotConstructor

BUG=v8:5671
==========

[commit-bot: I haz the power, 2017-02-12 22:40:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-12 22:40:16]

Dry run: This issue passed the CQ dry run.

[vabr (Chromium), 2017-02-12 22:46:34]

vabr@chromium.org changed reviewers:
+ akos.palfi@imgtec.com, chunyang.dai@intel.com, jarin@chromium.org,
michael_dawson@ca.ibm.com

[vabr (Chromium), 2017-02-12 22:46:35]

Hi all,
Could you please review as follows?

michael_dawson@ca.ibm.com: ppc and s390

chunyang.dai@intel.com: x87

akos.palfi@imgtec.com: mips and mips64

jarin@chromium.org: the rest of the CL

Thanks!
Vaclav

[Benedikt Meurer, 2017-02-14 04:06:01]

bmeurer@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Benedikt Meurer, 2017-02-14 04:06:02]

LGTM. Thanks!

[Benedikt Meurer, 2017-02-14 04:07:49]

Err, sorry, forgot to send comments. Please fix the naming.

https://codereview.chromium.org/2688393003/diff/40001/src/runtime/runtime-int...
File src/runtime/runtime-internal.cc (right):

https://codereview.chromium.org/2688393003/diff/40001/src/runtime/runtime-int...
src/runtime/runtime-internal.cc:369: RUNTIME_FUNCTION(Runtime_NotConstructor) {
Please rename this to ThrowNotConstructor.

[miran.karic, 2017-02-14 07:37:15]

mips lgtm, Akos no longer works on mips.

[vabr (Chromium), 2017-02-14 10:48:20]

Thanks for the review, Miran and Benedikt.

I renamed the runtime method as requested. Because Benedikt's approval covers
everything, and the changes in ppc, s390 and x87 are very simple, I will not
wait for the remaining reviewers. Sending this to the CQ now.

Cheers,
Vaclav

https://codereview.chromium.org/2688393003/diff/40001/src/runtime/runtime-int...
File src/runtime/runtime-internal.cc (right):

https://codereview.chromium.org/2688393003/diff/40001/src/runtime/runtime-int...
src/runtime/runtime-internal.cc:369: RUNTIME_FUNCTION(Runtime_NotConstructor) {
On 2017/02/14 04:07:49, Benedikt Meurer wrote:
> Please rename this to ThrowNotConstructor.

Done.

[vabr (Chromium), 2017-02-14 10:48:26]

The CQ bit was checked by vabr@chromium.org

[vabr (Chromium), 2017-02-14 10:48:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
Miran.Karic@imgtec.com, bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/2688393003/#ps80001
(title: "Fix order in runtime-internal.cc")

[commit-bot: I haz the power, 2017-02-14 10:48:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 11:21:36]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1487069306473180,
"parent_rev": "296553bf82b1d78d9bfd36dbbe2b31cfd4a151d1", "commit_rev":
"b478e9c11c3b01e4b34607182bab4774334f0e4d"}

[commit-bot: I haz the power, 2017-02-14 11:21:41]

Description was changed from

==========
Fix TypeError message for Reflect.construct

If the Reflect.construct receives an argument expected to be a constructor,
and the argument is not a constructor, V8 currently declares that
Reflect.construct is not a function. It should instead say that the offending
argument is not a constructor.

This is the case for all ports of builtins
(Builtins::Generate_ReflectConstruct). All of them make an
attempt to at least pass the right argument to the TypeError parametrised
message, calling out the offending Reflect.construct argument. However,
Runtime::kThrowCalledNonCallable extracts the callsite from those arguments,
discarding the precise information.

This CL adds Runtime::kNotConstructor, which reports the arguments passed
to it, and the CL also modifies the ports of builtins to make use of
Runtime::kNotConstructor

BUG=v8:5671
==========

to

==========
Fix TypeError message for Reflect.construct

If the Reflect.construct receives an argument expected to be a constructor,
and the argument is not a constructor, V8 currently declares that
Reflect.construct is not a function. It should instead say that the offending
argument is not a constructor.

This is the case for all ports of builtins
(Builtins::Generate_ReflectConstruct). All of them make an
attempt to at least pass the right argument to the TypeError parametrised
message, calling out the offending Reflect.construct argument. However,
Runtime::kThrowCalledNonCallable extracts the callsite from those arguments,
discarding the precise information.

This CL adds Runtime::kNotConstructor, which reports the arguments passed
to it, and the CL also modifies the ports of builtins to make use of
Runtime::kNotConstructor

BUG=v8:5671

Review-Url: https://codereview.chromium.org/2688393003
Cr-Commit-Position: refs/heads/master@{#43182}
Committed:
https://chromium.googlesource.com/v8/v8/+/b478e9c11c3b01e4b34607182bab4774334...
==========

[commit-bot: I haz the power, 2017-02-14 11:21:42]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/b478e9c11c3b01e4b34607182bab4774334...