Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/builtins/s390/builtins-s390.cc

Issue 2688393003: Fix TypeError message for Reflect.construct (Closed)
Patch Set: Fix order in runtime-internal.cc Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/builtins/ppc/builtins-ppc.cc ('k') | src/builtins/x64/builtins-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_S390 5 #if V8_TARGET_ARCH_S390
6 6
7 #include "src/codegen.h" 7 #include "src/codegen.h"
8 #include "src/debug/debug.h" 8 #include "src/debug/debug.h"
9 #include "src/deoptimizer.h" 9 #include "src/deoptimizer.h"
10 #include "src/full-codegen/full-codegen.h" 10 #include "src/full-codegen/full-codegen.h"
(...skipping 2096 matching lines...) Expand 10 before | Expand all | Expand 10 after
2107 __ TestBit(r6, Map::kIsConstructor); 2107 __ TestBit(r6, Map::kIsConstructor);
2108 __ beq(&new_target_not_constructor); 2108 __ beq(&new_target_not_constructor);
2109 2109
2110 // 4a. Construct the target with the given new.target and argumentsList. 2110 // 4a. Construct the target with the given new.target and argumentsList.
2111 __ Jump(masm->isolate()->builtins()->Apply(), RelocInfo::CODE_TARGET); 2111 __ Jump(masm->isolate()->builtins()->Apply(), RelocInfo::CODE_TARGET);
2112 2112
2113 // 4b. The target is not a constructor, throw an appropriate TypeError. 2113 // 4b. The target is not a constructor, throw an appropriate TypeError.
2114 __ bind(&target_not_constructor); 2114 __ bind(&target_not_constructor);
2115 { 2115 {
2116 __ StoreP(r3, MemOperand(sp, 0)); 2116 __ StoreP(r3, MemOperand(sp, 0));
2117 __ TailCallRuntime(Runtime::kThrowCalledNonCallable); 2117 __ TailCallRuntime(Runtime::kThrowNotConstructor);
2118 } 2118 }
2119 2119
2120 // 4c. The new.target is not a constructor, throw an appropriate TypeError. 2120 // 4c. The new.target is not a constructor, throw an appropriate TypeError.
2121 __ bind(&new_target_not_constructor); 2121 __ bind(&new_target_not_constructor);
2122 { 2122 {
2123 __ StoreP(r5, MemOperand(sp, 0)); 2123 __ StoreP(r5, MemOperand(sp, 0));
2124 __ TailCallRuntime(Runtime::kThrowCalledNonCallable); 2124 __ TailCallRuntime(Runtime::kThrowNotConstructor);
2125 } 2125 }
2126 } 2126 }
2127 2127
2128 static void EnterArgumentsAdaptorFrame(MacroAssembler* masm) { 2128 static void EnterArgumentsAdaptorFrame(MacroAssembler* masm) {
2129 __ SmiTag(r2); 2129 __ SmiTag(r2);
2130 __ LoadSmiLiteral(r6, Smi::FromInt(StackFrame::ARGUMENTS_ADAPTOR)); 2130 __ LoadSmiLiteral(r6, Smi::FromInt(StackFrame::ARGUMENTS_ADAPTOR));
2131 // Stack updated as such: 2131 // Stack updated as such:
2132 // old SP ---> 2132 // old SP --->
2133 // R14 Return Addr 2133 // R14 Return Addr
2134 // Old FP <--- New FP 2134 // Old FP <--- New FP
(...skipping 1076 matching lines...) Expand 10 before | Expand all | Expand 10 after
3211 __ bkpt(0); 3211 __ bkpt(0);
3212 } 3212 }
3213 } 3213 }
3214 3214
3215 #undef __ 3215 #undef __
3216 3216
3217 } // namespace internal 3217 } // namespace internal
3218 } // namespace v8 3218 } // namespace v8
3219 3219
3220 #endif // V8_TARGET_ARCH_S390 3220 #endif // V8_TARGET_ARCH_S390
OLDNEW
« no previous file with comments | « src/builtins/ppc/builtins-ppc.cc ('k') | src/builtins/x64/builtins-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698