Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 2688263002: EME: close() should return a resolved promise if session already closed (Closed)

Created:
3 years, 10 months ago by jrummell
Modified:
3 years, 10 months ago
Reviewers:
xhwang
CC:
chromium-reviews, mlamouri+watch-blink_chromium.org, eric.carlson_apple.com, haraken, feature-media-reviews_chromium.org, blink-reviews, Srirama
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

EME: close() should return a resolved promise if session already closed BUG=690664 TEST=new test passes Review-Url: https://codereview.chromium.org/2688263002 Cr-Commit-Position: refs/heads/master@{#449804} Committed: https://chromium.googlesource.com/chromium/src/+/665c048b2e508b5cc566810816a77bfd4bfdb9db

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-session-multiple-close-sequential.html View 1 chunk +46 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
jrummell
PTAL.
3 years, 10 months ago (2017-02-10 21:03:43 UTC) #2
xhwang
LGTM Please also get blink owner's approval.
3 years, 10 months ago (2017-02-10 21:22:22 UTC) #3
jrummell
Thanks for the review. Fix was suggested in the bug.
3 years, 10 months ago (2017-02-10 21:43:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2688263002/1
3 years, 10 months ago (2017-02-10 21:44:14 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-11 00:26:04 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/665c048b2e508b5cc566810816a7...

Powered by Google App Engine
This is Rietveld 408576698