third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.cpp - Issue 2688263002: EME: close() should return a resolved promise if session already closed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.cpp

Issue 2688263002: EME: close() should return a resolved promise if session already closed (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-session-multiple-close-sequential.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.cpp

diff --git a/third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.cpp b/third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.cpp

index e992b4b5ed03a8fb5241dc719b219e62dc21792c..d4a4d412c14d890d49a38424658bce8bd606bbbd 100644

--- a/third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.cpp

+++ b/third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.cpp

@@ -762,7 +762,7 @@ ScriptPromise MediaKeySession::close(ScriptState* scriptState) {

// 1. Let session be the associated MediaKeySession object.

// 2. If session is closed, return a resolved promise.

if (m_isClosed)

- return ScriptPromise::cast(scriptState, ScriptValue());

+ return ScriptPromise::castUndefined(scriptState);

// 3. If session's callable value is false, return a promise rejected with

// an InvalidStateError.