Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2688243004: [inspector] migrated Debugger.setBreakpointsActive to native (Closed)

Created:
3 years, 10 months ago by kozy
Modified:
3 years, 10 months ago
Reviewers:
pfeldman, Yang, jgruber
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] migrated Debugger.setBreakpointsActive to native BUG=none R=pfeldman@chromium.org,yangguo@chromium.org,jgruber@chromium.org Review-Url: https://codereview.chromium.org/2688243004 Cr-Commit-Position: refs/heads/master@{#43136} Committed: https://chromium.googlesource.com/v8/v8/+/ff10ed552035a380e028fd5359fa29aaeae79b75

Patch Set 1 #

Patch Set 2 : dont change state of disabled agent #

Patch Set 3 : revert bigger part :) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -47 lines) Patch
M src/api.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/debug/debug-interface.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/inspector/debugger-script.js View 1 chunk +0 lines, -9 lines 0 comments Download
M src/inspector/debugger_script_externs.js View 2 chunks +0 lines, -18 lines 0 comments Download
M src/inspector/v8-debugger.cc View 1 1 chunk +1 line, -20 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (10 generated)
kozy
Pavel and Jacob, please take a look.
3 years, 10 months ago (2017-02-11 01:11:05 UTC) #5
pfeldman
refactoring award is waiting for you! lgtm.
3 years, 10 months ago (2017-02-11 01:18:11 UTC) #7
Yang
On 2017/02/11 01:18:11, pfeldman wrote: > refactoring award is waiting for you! lgtm. lgtm.
3 years, 10 months ago (2017-02-13 06:09:56 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2688243004/40001
3 years, 10 months ago (2017-02-13 06:49:07 UTC) #12
jgruber
lgtm, awesome.
3 years, 10 months ago (2017-02-13 07:00:30 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 07:13:50 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/ff10ed552035a380e028fd5359fa29aaeae...

Powered by Google App Engine
This is Rietveld 408576698