Make all member variables in DownloadNotificationService final

Make all member variables in DownloadNotificationService final

Some of the member variables are not final in DNS.
This allows another class to modify those variables without DNS knowing it.
As a result, such modifications is not written into the SharedPreferences.
To address this, other classes should make a new DownloadSharedPreferenceEntry
and call AddOrReplace function to inform DNS about the modification.

TBR=dfalcantara@chromium.org
BUG=690080
Review-Url: https://codereview.chromium.org/2679933005
Cr-Commit-Position: refs/heads/master@{#449513}
(cherry picked from commit 5bd7014090760813fb68a78a03d4ff90803cdffc)

Review-Url: https://codereview.chromium.org/2688243002 .
Cr-Commit-Position: refs/branch-heads/2987@{#450}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed: https://chromium.googlesource.com/chromium/src/+/e5010a4817336dfc3290463c114a2691352d5466

[qinmin, 2017-02-10 20:43:41]

Description was changed from

==========
Make all member variables in DownloadNotificationService final

Some of the member variables are not final in DNS.
This allows another class to modify those variables without DNS knowing it.
As a result, such modifications is not written into the SharedPreferences.
To address this, other classes should make a new DownloadSharedPreferenceEntry
and call AddOrReplace function to inform DNS about the modification.

TBR=dfalcantara@chromium.org
BUG=690080

Review-Url: https://codereview.chromium.org/2679933005
Cr-Commit-Position: refs/heads/master@{#449513}
(cherry picked from commit 5bd7014090760813fb68a78a03d4ff90803cdffc)
==========

to

==========
Make all member variables in DownloadNotificationService final

Some of the member variables are not final in DNS.
This allows another class to modify those variables without DNS knowing it.
As a result, such modifications is not written into the SharedPreferences.
To address this, other classes should make a new DownloadSharedPreferenceEntry
and call AddOrReplace function to inform DNS about the modification.

TBR=dfalcantara@chromium.org
BUG=690080

Review-Url: https://codereview.chromium.org/2679933005
Cr-Commit-Position: refs/heads/master@{#449513}
(cherry picked from commit 5bd7014090760813fb68a78a03d4ff90803cdffc)

Review-Url: https://codereview.chromium.org/2688243002 .
Cr-Commit-Position: refs/branch-heads/2987@{#450}
Cr-Branched-From:
ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed:
https://chromium.googlesource.com/chromium/src/+/e5010a4817336dfc3290463c114a...
==========

[qinmin, 2017-02-10 20:43:42]

Committed patchset #1 (id:1) manually as
e5010a4817336dfc3290463c114a2691352d5466 (presubmit successful).