Make all member variables in DownloadNotificationService final

Make all member variables in DownloadNotificationService final

Some of the member variables are not final in DNS.
This allows another class to modify those variables without DNS knowing it.
As a result, such modifications is not written into the SharedPreferences.
To address this, other classes should make a new DownloadSharedPreferenceEntry
and call AddOrReplace function to inform DNS about the modification.

BUG=690080
Review-Url: https://codereview.chromium.org/2679933005
Cr-Commit-Position: refs/heads/master@{#449513}
Committed: https://chromium.googlesource.com/chromium/src/+/5bd7014090760813fb68a78a03d4ff90803cdffc

[qinmin, 2017-02-08 19:44:22]

qinmin@chromium.org changed reviewers:
+ dfalcantara@chromium.org, shaktisahu@chromium.org

[qinmin, 2017-02-08 19:44:22]

PTAL

[gone, 2017-02-09 23:24:43]

lgtm

[qinmin, 2017-02-09 23:35:43]

The CQ bit was checked by qinmin@chromium.org

[commit-bot: I haz the power, 2017-02-09 23:36:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 00:50:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 00:50:09]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[qinmin, 2017-02-10 01:33:29]

The CQ bit was checked by qinmin@chromium.org

[commit-bot: I haz the power, 2017-02-10 01:34:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 02:08:07]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486690409036970, "parent_rev":
"bf872a68fb2fa7d3f039373dc65ea322146569f8", "commit_rev":
"5bd7014090760813fb68a78a03d4ff90803cdffc"}

[commit-bot: I haz the power, 2017-02-10 02:09:31]

Description was changed from

==========
Make all member variables in DownloadNotificationService final

Some of the member variables are not final in DNS.
This allows another class to modify those variables without DNS knowing it.
As a result, such modifications is not written into the SharedPreferences.
To address this, other classes should make a new DownloadSharedPreferenceEntry
and call AddOrReplace function to inform DNS about the modification.

BUG=690080
==========

to

==========
Make all member variables in DownloadNotificationService final

Some of the member variables are not final in DNS.
This allows another class to modify those variables without DNS knowing it.
As a result, such modifications is not written into the SharedPreferences.
To address this, other classes should make a new DownloadSharedPreferenceEntry
and call AddOrReplace function to inform DNS about the modification.

BUG=690080

Review-Url: https://codereview.chromium.org/2679933005
Cr-Commit-Position: refs/heads/master@{#449513}
Committed:
https://chromium.googlesource.com/chromium/src/+/5bd7014090760813fb68a78a03d4...
==========

[commit-bot: I haz the power, 2017-02-10 02:09:32]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5bd7014090760813fb68a78a03d4...