Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2688083002: Move VisitorMarkingMode into Visitor. (Closed)

Created:
3 years, 10 months ago by sof
Modified:
3 years, 10 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move VisitorMarkingMode into Visitor. Move this enum back into Visitor where it better belongs; recent simplifications to the marking visitor implementation class types makes that a trivial exercise. R=haraken BUG=671856 Review-Url: https://codereview.chromium.org/2688083002 Cr-Commit-Position: refs/heads/master@{#449568} Committed: https://chromium.googlesource.com/chromium/src/+/6b36348853ac5de0419f2b2b1e70e6db057d1202

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -43 lines) Patch
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Visitor.h View 4 chunks +24 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Visitor.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/VisitorImpl.h View 6 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
sof
please take a look.
3 years, 10 months ago (2017-02-10 07:36:05 UTC) #2
haraken
LGTM
3 years, 10 months ago (2017-02-10 07:37:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2688083002/1
3 years, 10 months ago (2017-02-10 07:39:24 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 09:12:29 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6b36348853ac5de0419f2b2b1e70...

Powered by Google App Engine
This is Rietveld 408576698