third_party/WebKit/Source/platform/heap/HeapTest.cpp - Issue 2688083002: Move VisitorMarkingMode into Visitor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/heap/HeapTest.cpp

Issue 2688083002: Move VisitorMarkingMode into Visitor. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/heap/HeapTest.cpp

diff --git a/third_party/WebKit/Source/platform/heap/HeapTest.cpp b/third_party/WebKit/Source/platform/heap/HeapTest.cpp

index f8b1a87f53bdb45815cb140f9f4d2e6f32c113d1..2ba029352953a684f8184d3ebb0d27621721f6b2 100644

--- a/third_party/WebKit/Source/platform/heap/HeapTest.cpp

+++ b/third_party/WebKit/Source/platform/heap/HeapTest.cpp

@@ -3785,7 +3785,7 @@ TEST(HeapTest, CheckAndMarkPointer) {

{

TestGCScope scope(BlinkGC::HeapPointersOnStack);

ThreadState::GCForbiddenScope gcScope(ThreadState::current());

- Visitor visitor(ThreadState::current(), VisitorMarkingMode::GlobalMarking);

+ Visitor visitor(ThreadState::current(), Visitor::GlobalMarking);

EXPECT_TRUE(scope.allThreadsParked()); // Fail the test if we could not

// park all threads.

heap.flushHeapDoesNotContainCache();

@@ -3811,7 +3811,7 @@ TEST(HeapTest, CheckAndMarkPointer) {

{

TestGCScope scope(BlinkGC::HeapPointersOnStack);

ThreadState::GCForbiddenScope gcScope(ThreadState::current());

- Visitor visitor(ThreadState::current(), VisitorMarkingMode::GlobalMarking);

+ Visitor visitor(ThreadState::current(), Visitor::GlobalMarking);

EXPECT_TRUE(scope.allThreadsParked());

heap.flushHeapDoesNotContainCache();

for (size_t i = 0; i < objectAddresses.size(); i++) {

« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/heap/ThreadState.cpp » ('j') | no next file with comments »