Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2687973003: Revert of [Compiler] Enable handles created during parsing and scope analysis to be deferred. (Closed)

Created:
3 years, 10 months ago by rmcilroy
Modified:
3 years, 10 months ago
Reviewers:
marja
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [Compiler] Enable handles created during parsing and scope analysis to be deferred. (patchset #9 id:180001 of https://codereview.chromium.org/2650883002/ ) Reason for revert: Issue on arm64: https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%20-%20sim/builds/5752 Original issue's description: > [Compiler] Enable handles created during parsing and scope analysis to be deferred. > > In order to compile eager inner functions on a background thread we need to > keep the handles created during parsing and scope analysis alive until the > background compilation is complete. In order to do that, we allocate the > handles in a deferred handle scope and keep the deferred handles alive with > a shared_ptr in the ParseInfo and CompileInfo respectively. > > BUG=v8:5203 > > Review-Url: https://codereview.chromium.org/2650883002 > Cr-Commit-Position: refs/heads/master@{#43091} > Committed: https://chromium.googlesource.com/v8/v8/+/9346cd9b4c50466aa8d50e98c56b84ba47c2a115 TBR=marja@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5203 Review-Url: https://codereview.chromium.org/2687973003 Cr-Commit-Position: refs/heads/master@{#43093} Committed: https://chromium.googlesource.com/v8/v8/+/fa4f0347c11fad6ffdbdfd734aa7d67b9325debc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -269 lines) Patch
M src/api.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/api.cc View 1 chunk +6 lines, -13 lines 0 comments Download
M src/compilation-info.h View 2 chunks +4 lines, -5 lines 0 comments Download
M src/compilation-info.cc View 2 chunks +2 lines, -14 lines 0 comments Download
M src/compiler.cc View 7 chunks +12 lines, -54 lines 0 comments Download
M src/compiler-dispatcher/compiler-dispatcher.h View 2 chunks +2 lines, -10 lines 0 comments Download
M src/compiler-dispatcher/compiler-dispatcher.cc View 3 chunks +6 lines, -15 lines 0 comments Download
M src/compiler-dispatcher/compiler-dispatcher-job.h View 3 chunks +2 lines, -9 lines 0 comments Download
M src/compiler-dispatcher/compiler-dispatcher-job.cc View 6 chunks +19 lines, -21 lines 0 comments Download
M src/handles.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/parsing/parse-info.h View 4 chunks +2 lines, -14 lines 0 comments Download
M src/parsing/parse-info.cc View 3 chunks +1 line, -14 lines 0 comments Download
M src/parsing/parser.h View 1 chunk +5 lines, -6 lines 0 comments Download
M src/parsing/parser.cc View 1 chunk +15 lines, -12 lines 0 comments Download
M src/parsing/parsing.h View 1 chunk +6 lines, -8 lines 0 comments Download
M src/parsing/parsing.cc View 3 chunks +7 lines, -19 lines 0 comments Download
M src/pending-compilation-error-handler.h View 2 chunks +15 lines, -0 lines 0 comments Download
M src/pending-compilation-error-handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/compiler-dispatcher/compiler-dispatcher-unittest.cc View 5 chunks +7 lines, -53 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
rmcilroy
Created Revert of [Compiler] Enable handles created during parsing and scope analysis to be deferred.
3 years, 10 months ago (2017-02-10 12:30:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2687973003/1
3 years, 10 months ago (2017-02-10 12:30:15 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 12:30:31 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/fa4f0347c11fad6ffdbdfd734aa7d67b932...

Powered by Google App Engine
This is Rietveld 408576698