Reland: [Compiler] Enable handles created during parsing and scope analysis to be deferred.

Reland: [Compiler] Enable handles created during parsing and scope analysis to be deferred.
    
In order to compile eager inner functions on a background thread we need to
keep the handles created during parsing and scope analysis alive until the
background compilation is complete. In order to do that, we allocate the
handles in a deferred handle scope and keep the deferred handles alive with
a shared_ptr in the ParseInfo and CompileInfo respectively.
    
BUG=v8:5203
Review-Url: https://codereview.chromium.org/2650883002
Cr-Commit-Position: refs/heads/master@{#43107}
Committed: https://chromium.googlesource.com/v8/v8/+/0a9d4a3b0c8097dc39ec95f7ab750b59e29cbc8a

[rmcilroy, 2017-01-23 22:18:44]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-23 22:18:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 22:38:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 22:38:58]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_asan_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_trig...)
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/21381)
  v8_win64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng_triggered/b...)

[rmcilroy, 2017-01-23 22:52:27]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-23 22:52:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 23:08:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 23:08:10]

Dry run: Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)
  v8_win_nosnap_shared_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[rmcilroy, 2017-01-24 00:32:55]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 00:32:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 00:53:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 00:53:39]

Dry run: Try jobs failed on following builders:
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/19762)
  v8_linux64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng_triggered...)

[rmcilroy, 2017-02-07 14:31:21]

Description was changed from

==========
[Compiler] Store handles created during parsing in a deferred handle scope.

Adds deferred_handles to ParseInfo which is used to retain the handles
created during parsing. This enables them to stay live while background
compilation jobs compile eager inner functions.

BUG=v8:5203,v8:5215
==========

to

==========
[Compiler] Enable handles created during parsing and scope analysis to be
deferred.
    
In order to compile eager inner functions on a background thread we need to
keep the handles created during parsing and scope analysis alive until the
background compilation is complete. In order to do that, we allocate the
handles in a deferred handle scope and keep the deferred handles alive with
a shared_ptr in the ParseInfo and CompileInfo respectively.
    
BUG=v8:5203
==========

[rmcilroy, 2017-02-07 14:31:49]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 14:31:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 14:54:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 14:54:48]

Dry run: Try jobs failed on following builders:
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/20542)
  v8_linux64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng_triggered...)

[rmcilroy, 2017-02-07 17:06:01]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 17:06:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rmcilroy, 2017-02-07 17:27:08]

rmcilroy@chromium.org changed reviewers:
+ marja@chromium.org

[rmcilroy, 2017-02-07 17:27:09]

Marja, PTAL. This is the next step in enabling off-thread compilation. I had to
decouple error reporting and internalization because I need to have a
DeferredHandleScope during internalization, however if I'm in a
DeferredHandleScope when reporting errors the debugger can cause us to start
compiling more JS code to report the error, which causes us to create a nested
DeferredHandleScope which isn't allowed.

After this change we have all the pieces to enable us to decouple the inner
function compilation from the outer function compilation (I'll upload a CL for
that soon).

[commit-bot: I haz the power, 2017-02-07 17:34:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 17:34:27]

Dry run: This issue passed the CQ dry run.

[marja, 2017-02-08 09:50:30]

lgtm

[rmcilroy, 2017-02-08 23:19:00]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 23:19:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rmcilroy, 2017-02-08 23:22:25]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 23:22:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 23:32:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 23:32:25]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[rmcilroy, 2017-02-08 23:45:52]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 23:45:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 23:53:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 23:53:09]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[rmcilroy, 2017-02-09 00:04:00]

Patchset #8 (id:140001) has been deleted

[rmcilroy, 2017-02-10 10:29:03]

The CQ bit was checked by rmcilroy@chromium.org

[rmcilroy, 2017-02-10 10:29:03]

The patchset sent to the CQ was uploaded after l-g-t-m from marja@chromium.org
Link to the patchset: https://codereview.chromium.org/2650883002/#ps160001
(title: "And DeferredHandles")

[commit-bot: I haz the power, 2017-02-10 10:29:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 10:37:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 10:37:45]

Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[rmcilroy, 2017-02-10 11:23:48]

The CQ bit was checked by rmcilroy@chromium.org

[rmcilroy, 2017-02-10 11:23:48]

The patchset sent to the CQ was uploaded after l-g-t-m from marja@chromium.org
Link to the patchset: https://codereview.chromium.org/2650883002/#ps180001
(title: "Remove unused variable")

[commit-bot: I haz the power, 2017-02-10 11:23:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 11:46:14]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1486725828311020,
"parent_rev": "c46ccef921ee754d60283d132b9d19f64ae7b1ff", "commit_rev":
"9346cd9b4c50466aa8d50e98c56b84ba47c2a115"}

[commit-bot: I haz the power, 2017-02-10 11:46:19]

Description was changed from

==========
[Compiler] Enable handles created during parsing and scope analysis to be
deferred.
    
In order to compile eager inner functions on a background thread we need to
keep the handles created during parsing and scope analysis alive until the
background compilation is complete. In order to do that, we allocate the
handles in a deferred handle scope and keep the deferred handles alive with
a shared_ptr in the ParseInfo and CompileInfo respectively.
    
BUG=v8:5203
==========

to

==========
[Compiler] Enable handles created during parsing and scope analysis to be
deferred.
    
In order to compile eager inner functions on a background thread we need to
keep the handles created during parsing and scope analysis alive until the
background compilation is complete. In order to do that, we allocate the
handles in a deferred handle scope and keep the deferred handles alive with
a shared_ptr in the ParseInfo and CompileInfo respectively.
    
BUG=v8:5203

Review-Url: https://codereview.chromium.org/2650883002
Cr-Commit-Position: refs/heads/master@{#43091}
Committed:
https://chromium.googlesource.com/v8/v8/+/9346cd9b4c50466aa8d50e98c56b84ba47c...
==========

[commit-bot: I haz the power, 2017-02-10 11:46:20]

Committed patchset #9 (id:180001) as
https://chromium.googlesource.com/v8/v8/+/9346cd9b4c50466aa8d50e98c56b84ba47c...

[rmcilroy, 2017-02-10 12:30:06]

A revert of this CL (patchset #9 id:180001) has been created in
https://codereview.chromium.org/2687973003/ by rmcilroy@chromium.org.

The reason for reverting is: Issue on arm64: 
https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%....

[rmcilroy, 2017-02-10 14:58:13]

Description was changed from

==========
[Compiler] Enable handles created during parsing and scope analysis to be
deferred.
    
In order to compile eager inner functions on a background thread we need to
keep the handles created during parsing and scope analysis alive until the
background compilation is complete. In order to do that, we allocate the
handles in a deferred handle scope and keep the deferred handles alive with
a shared_ptr in the ParseInfo and CompileInfo respectively.
    
BUG=v8:5203

Review-Url: https://codereview.chromium.org/2650883002
Cr-Commit-Position: refs/heads/master@{#43091}
Committed:
https://chromium.googlesource.com/v8/v8/+/9346cd9b4c50466aa8d50e98c56b84ba47c...
==========

to

==========
Reland: [Compiler] Enable handles created during parsing and scope analysis to
be deferred.
    
In order to compile eager inner functions on a background thread we need to
keep the handles created during parsing and scope analysis alive until the
background compilation is complete. In order to do that, we allocate the
handles in a deferred handle scope and keep the deferred handles alive with
a shared_ptr in the ParseInfo and CompileInfo respectively.
    
BUG=v8:5203
==========

[rmcilroy, 2017-02-10 14:58:56]

On 2017/02/10 12:30:06, rmcilroy wrote:
> A revert of this CL (patchset #9 id:180001) has been created in
> https://codereview.chromium.org/2687973003/ by mailto:rmcilroy@chromium.org.
> 
> The reason for reverting is: Issue on arm64: 
>
https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%....

Relanding since this CL wasn't the reason for the Arm64 failure (see
https://bugs.chromium.org/p/v8/issues/detail?id=5956)

[rmcilroy, 2017-02-10 14:59:03]

The CQ bit was checked by rmcilroy@chromium.org

[commit-bot: I haz the power, 2017-02-10 14:59:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 15:01:30]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1486738743450070,
"parent_rev": "bfd65a54fa6b531e72e7e6c5610227573de01bd3", "commit_rev":
"0a9d4a3b0c8097dc39ec95f7ab750b59e29cbc8a"}

[commit-bot: I haz the power, 2017-02-10 15:01:34]

Description was changed from

==========
Reland: [Compiler] Enable handles created during parsing and scope analysis to
be deferred.
    
In order to compile eager inner functions on a background thread we need to
keep the handles created during parsing and scope analysis alive until the
background compilation is complete. In order to do that, we allocate the
handles in a deferred handle scope and keep the deferred handles alive with
a shared_ptr in the ParseInfo and CompileInfo respectively.
    
BUG=v8:5203
==========

to

==========
Reland: [Compiler] Enable handles created during parsing and scope analysis to
be deferred.
    
In order to compile eager inner functions on a background thread we need to
keep the handles created during parsing and scope analysis alive until the
background compilation is complete. In order to do that, we allocate the
handles in a deferred handle scope and keep the deferred handles alive with
a shared_ptr in the ParseInfo and CompileInfo respectively.
    
BUG=v8:5203

Review-Url: https://codereview.chromium.org/2650883002
Cr-Commit-Position: refs/heads/master@{#43107}
Committed:
https://chromium.googlesource.com/v8/v8/+/0a9d4a3b0c8097dc39ec95f7ab750b59e29...
==========

[commit-bot: I haz the power, 2017-02-10 15:01:36]

Committed patchset #9 (id:180001) as
https://chromium.googlesource.com/v8/v8/+/0a9d4a3b0c8097dc39ec95f7ab750b59e29...