Clear the text cache when the tooltip text is updated.

Clear the text cache when the tooltip text is updated.

BUG=689863
TEST=BookmarkBarViewTest.UpdateTooltipText

Review-Url: https://codereview.chromium.org/2687893002
Cr-Commit-Position: refs/heads/master@{#451591}
Committed: https://chromium.googlesource.com/chromium/src/+/3dc0899d326b4d59ef71b6a49a7a786ab28a3125

[oshima, 2017-02-09 14:58:27]

Patchset #1 (id:1) has been deleted

[oshima, 2017-02-09 15:00:58]

Description was changed from

==========
Tooltip

BUG=
==========

to

==========
Clear the text cache when the tooltip text is updated.

BUG=689863
TEST=BookmarkBarViewTest.UpdateTooltipText
==========

[oshima, 2017-02-09 15:00:59]

oshima@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2017-02-09 20:30:40]

https://codereview.chromium.org/2687893002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc (right):

https://codereview.chromium.org/2687893002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc:282: LOG(ERROR) << "New
Tooltip:" << tooltip_text_;
Remove this.

https://codereview.chromium.org/2687893002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/bookmarks/bookmark_bar_view_browsertest.cc (right):

https://codereview.chromium.org/2687893002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/bookmarks/bookmark_bar_view_browsertest.cc:20:
IN_PROC_BROWSER_TEST_F(BookmarkBarViewTest, UpdateTooltipText) {
Are you sure you need a browsertest for this? I'm wondering if you can use a
unit test.

[oshima, 2017-02-13 04:27:52]

Patchset #4 (id:80001) has been deleted

[oshima, 2017-02-13 04:28:03]

Patchset #3 (id:60001) has been deleted

[oshima, 2017-02-13 04:37:24]

https://codereview.chromium.org/2687893002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc (right):

https://codereview.chromium.org/2687893002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc:282: LOG(ERROR) << "New
Tooltip:" << tooltip_text_;
On 2017/02/09 20:30:40, sky wrote:
> Remove this.

Done.

https://codereview.chromium.org/2687893002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/bookmarks/bookmark_bar_view_browsertest.cc (right):

https://codereview.chromium.org/2687893002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/bookmarks/bookmark_bar_view_browsertest.cc:20:
IN_PROC_BROWSER_TEST_F(BookmarkBarViewTest, UpdateTooltipText) {
On 2017/02/09 20:30:40, sky wrote:
> Are you sure you need a browsertest for this? I'm wondering if you can use a
> unit test.

I moved to unit test. I had to create a fake widget because a browser in
BrowserWithTestWindowTest has no views in it. Let me know if there is a better
way.

[sky, 2017-02-13 17:46:36]

LGTM

[oshima, 2017-02-14 00:27:25]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2017-02-14 00:28:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 01:15:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 01:15:12]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[oshima, 2017-02-14 05:14:33]

https://codereview.chromium.org/2687893002/diff/120001/chrome/browser/ui/view...
File chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc (right):

https://codereview.chromium.org/2687893002/diff/120001/chrome/browser/ui/view...
chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc:373:
views::ScopedViewsTestHelper helper(std::move(views_delegate_for_setup));
Looks like I need to set up these for desktop aura (win/linux).
Let me know if I should put this in SetUp, or there is a better way.

[oshima, 2017-02-14 06:27:16]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 06:27:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 07:22:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 07:22:27]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sky, 2017-02-14 17:58:05]

https://codereview.chromium.org/2687893002/diff/120001/chrome/browser/ui/view...
File chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc (right):

https://codereview.chromium.org/2687893002/diff/120001/chrome/browser/ui/view...
chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc:368:
TEST_F(BookmarkBarViewTest, UpdateTooltipText) {
Would it make more sense to have this test extend ViewsTestBase?

[oshima, 2017-02-17 01:31:35]

Patchset #5 (id:140001) has been deleted

[oshima, 2017-02-17 01:31:41]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 01:34:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 03:38:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 03:38:04]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[oshima, 2017-02-17 17:30:25]

https://codereview.chromium.org/2687893002/diff/160001/chrome/browser/ui/view...
File chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc (right):

https://codereview.chromium.org/2687893002/diff/160001/chrome/browser/ui/view...
chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc:370: params,
&widget, nullptr);
looks like this is how views unit test should do for widget related tests.

PTAL.

[sky, 2017-02-17 20:52:06]

LGTM

[oshima, 2017-02-18 00:06:15]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2017-02-18 00:07:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 02:11:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-18 02:11:26]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[oshima, 2017-02-18 02:40:02]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2017-02-18 02:40:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 04:50:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-18 04:50:03]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[oshima, 2017-02-20 09:31:34]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2017-02-20 09:32:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 10:33:50]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1487583094422510,
"parent_rev": "f6cba6deea485d3647920ddd11fd4894b1a1a506", "commit_rev":
"3dc0899d326b4d59ef71b6a49a7a786ab28a3125"}

[commit-bot: I haz the power, 2017-02-20 10:34:29]

Description was changed from

==========
Clear the text cache when the tooltip text is updated.

BUG=689863
TEST=BookmarkBarViewTest.UpdateTooltipText
==========

to

==========
Clear the text cache when the tooltip text is updated.

BUG=689863
TEST=BookmarkBarViewTest.UpdateTooltipText

Review-Url: https://codereview.chromium.org/2687893002
Cr-Commit-Position: refs/heads/master@{#451591}
Committed:
https://chromium.googlesource.com/chromium/src/+/3dc0899d326b4d59ef71b6a49a7a...
==========

[commit-bot: I haz the power, 2017-02-20 10:34:31]

Committed patchset #5 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/3dc0899d326b4d59ef71b6a49a7a...