Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

Issue 2687893002: Clear the text cache when the tooltip text is updated. (Closed)
Patch Set: updated test Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
index 3010e8e8cff7dfca71a7306a42b9b3695d5d18ed..92dffc0d811ac1af762668d18907c19bf7232e23 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
+++ b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
@@ -250,7 +250,6 @@ class BookmarkButtonBase : public views::LabelButton {
private:
std::unique_ptr<gfx::SlideAnimation> show_animation_;
-
DISALLOW_COPY_AND_ASSIGN(BookmarkButtonBase);
};
@@ -289,7 +288,7 @@ class BookmarkButton : public BookmarkButtonBase {
void SetText(const base::string16& text) override {
BookmarkButtonBase::SetText(text);
- tooltip_text_.empty();
+ tooltip_text_.clear();
}
const char* GetClassName() const override { return kViewClassName; }

Powered by Google App Engine
This is Rietveld 408576698