Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 26876002: make explicit the requirement that all colorfilters are reentrant-safe (Closed)

Created:
6 years ago by reed1
Modified:
6 years ago
Reviewers:
mtklein
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

make explicit the requirement that all colorfilters are reentrant-safe BUG= R=mtklein@google.com Committed: https://code.google.com/p/skia/source/detail?r=11705

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -5 lines) Patch
M include/core/SkColorFilter.h View 1 chunk +8 lines, -0 lines 0 comments Download
M include/core/SkXfermode.h View 1 chunk +4 lines, -1 line 1 comment Download
M src/core/SkPicturePlayback.cpp View 1 chunk +4 lines, -4 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
reed1
6 years ago (2013-10-10 17:13:11 UTC) #1
reed1
6 years ago (2013-10-10 17:24:49 UTC) #2
mtklein
lgtm style nits only https://codereview.chromium.org/26876002/diff/1/include/core/SkXfermode.h File include/core/SkXfermode.h (right): https://codereview.chromium.org/26876002/diff/1/include/core/SkXfermode.h#newcode23 include/core/SkXfermode.h:23: SkXfermode is the base class ...
6 years ago (2013-10-10 17:33:14 UTC) #3
reed1
6 years ago (2013-10-10 17:36:03 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r11705 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698