Issue 26876002: make explicit the requirement that all colorfilters are reentrant-safe

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26876002: make explicit the requirement that all colorfilters are reentrant-safe (Closed)

Created:
7 years, 2 months ago by reed1

Modified:
7 years, 2 months ago

Reviewers:
mtklein

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

make explicit the requirement that all colorfilters are reentrant-safe BUG= R=mtklein@google.com Committed: https://code.google.com/p/skia/source/detail?r=11705

Patch Set 1 #

Total comments: 2

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -5 lines)			Patch
M	include/core/SkColorFilter.h	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	include/core/SkXfermode.h	View	1 chunk	+4 lines, -1 line	1 comment	Download
M	src/core/SkPicturePlayback.cpp	View	1 chunk	+4 lines, -4 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

mtklein

lgtm style nits only https://codereview.chromium.org/26876002/diff/1/include/core/SkXfermode.h File include/core/SkXfermode.h (right): https://codereview.chromium.org/26876002/diff/1/include/core/SkXfermode.h#newcode23 include/core/SkXfermode.h:23: SkXfermode is the base class ...

7 years, 2 months ago (2013-10-10 17:33:14 UTC) #3

reed1

7 years, 2 months ago (2013-10-10 17:36:03 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r11705 (presubmit successful).

Expand Messages | Collapse Messages