make explicit the requirement that all colorfilters are reentrant-safe

src/core/SkPicturePlayback.cpp

 
 /*
  * Copyright 2011 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 #include "SkPicturePlayback.h"
 #include "SkPictureRecord.h"
 #include "SkTypeface.h"
@@ skipping 132 matching lines @@
     if (regions != 0)
         SkDebugf("regions size %zd (regions:%d) ", regionBytes, regions);
     SkDebugf("\n");
 #endif
 }
 
 static bool needs_deep_copy(const SkPaint& paint) {
     /*
      *  These fields are known to be immutable, and so can be shallow-copied
      *
-     *  getTypeface();
-     *  getAnnotation();
-     *  getXfermode();
+     *  getTypeface()
+     *  getAnnotation()
+     *  paint.getColorFilter()

[mtklein, 2013/10/10 17:33:14]

remove paint.?

+     *  getXfermode()
      */
 
     return paint.getPathEffect() ||
            paint.getShader() ||
            paint.getMaskFilter() ||
-           paint.getColorFilter() ||
            paint.getRasterizer() ||
            paint.getLooper() ||
            paint.getImageFilter();
 }
 
 SkPicturePlayback::SkPicturePlayback(const SkPicturePlayback& src, SkPictCopyInfo* deepCopyInfo) {
     this->init();
 
     fBitmapHeap.reset(SkSafeRef(src.fBitmapHeap.get()));
     fPathHeap.reset(SkSafeRef(src.fPathHeap.get()));
@@ skipping 1485 matching lines @@
     for (index = 0; index < fRegionCount; index++)
         bufferPtr += snprintf(bufferPtr, DUMP_BUFFER_SIZE - (bufferPtr - pBuffer),
             "region%p, ", &fRegions[index]);
     if (fRegionCount > 0)
         SkDebugf("%s0};\n", pBuffer);
 
     const_cast<SkPicturePlayback*>(this)->dumpStream();
 }
 
 #endif