Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: src/core/SkPicturePlayback.cpp

Issue 26876002: make explicit the requirement that all colorfilters are reentrant-safe (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« include/core/SkXfermode.h ('K') | « include/core/SkXfermode.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/core/SkPicturePlayback.cpp
diff --git a/src/core/SkPicturePlayback.cpp b/src/core/SkPicturePlayback.cpp
index 04c90cee9277f98add60de4710d79de8babb7f96..f95c44343dc3ccada3289058760854a5213ad308 100644
--- a/src/core/SkPicturePlayback.cpp
+++ b/src/core/SkPicturePlayback.cpp
@@ -150,15 +150,15 @@ static bool needs_deep_copy(const SkPaint& paint) {
/*
* These fields are known to be immutable, and so can be shallow-copied
*
- * getTypeface();
- * getAnnotation();
- * getXfermode();
+ * getTypeface()
+ * getAnnotation()
+ * paint.getColorFilter()
mtklein 2013/10/10 17:33:14 remove paint.?
+ * getXfermode()
*/
return paint.getPathEffect() ||
paint.getShader() ||
paint.getMaskFilter() ||
- paint.getColorFilter() ||
paint.getRasterizer() ||
paint.getLooper() ||
paint.getImageFilter();
« include/core/SkXfermode.h ('K') | « include/core/SkXfermode.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698