Allow the user to tap the selected editable again after rotation to trigger another zoom/center ani…

Allow tap after rotation to trigger editable zoom/center animation

Normally, repeated taps on an editable node will not re-trigger the node focus
animation.  However, until crbug.com/363182 is resolved, rotation may not
always keep the editable in view.  Allow a tap after rotation to trigger the
focus animation.

BUG=363059

[ankit, 2014-05-02 06:18:22]

PTAL.
closed the older review request https://codereview.chromium.org/236733006/
raised with the wrong email id. And raising the same with samsung google
account. 
 
Please refer to  https://codereview.chromium.org/236733006/ for more
clearification.

[jdduke (slow), 2014-05-02 14:50:59]

On 2014/05/02 06:18:22, ankit2.kumar wrote:
> PTAL.
> closed the older review request https://codereview.chromium.org/236733006/
> raised with the wrong email id. And raising the same with samsung google
> account. 
>  
> Please refer to  https://codereview.chromium.org/236733006/ for more
> clearification.

I'm not an owner so you'll need to find another reviewer (jamesr is OOO).

[ankit, 2014-06-19 12:07:14]

@jamesr
PTAL
Please refer to https://codereview.chromium.org/236733006/
for more clearification.

[jamesr, 2014-06-19 17:53:58]

Where are the tests?

https://codereview.chromium.org/268753003/diff/20001/content/renderer/render_...
File content/renderer/render_view_impl.cc (right):

https://codereview.chromium.org/268753003/diff/20001/content/renderer/render_...
content/renderer/render_view_impl.cc:2873: // TODO(mlamouri): consumers of that
event should be using DisplayObserver.
you've split the TODO and the line it refers to. please put your code above this
comment, not below

https://codereview.chromium.org/268753003/diff/20001/content/renderer/render_...
content/renderer/render_view_impl.cc:2874:
has_scrolled_focused_editable_node_into_rect_ = false;
it's not at all clear why this line is here. could you add a comment?

if the user rotates the screen 90' then rotates it back, shouldn't another tap
in the same editable area be ignored? they'll be back where they started

[ankit, 2014-06-20 10:34:11]

Closing issue as Issue is not reproducible with latest code.
Vefied with build 37_2095.
After rotation when user is tapping on input field it's properly coming into
view with zoom event triggered.