Allow the user to tap the selected editable again after rotation to trigger another zoom/center ani…

content/renderer/render_view_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view_impl.h"
 
 #include <algorithm>
 #include <cmath>
 
 #include "base/auto_reset.h"
@@ skipping 2852 matching lines @@
   }
 }
 
 void RenderViewImpl::OnMediaPlayerActionAt(const gfx::Point& location,
                                            const WebMediaPlayerAction& action) {
   if (webview())
     webview()->performMediaPlayerAction(action, location);
 }
 
 void RenderViewImpl::OnOrientationChange() {
   // TODO(mlamouri): consumers of that event should be using DisplayObserver.

[jamesr, 2014/06/19 17:53:58]

you've split the TODO and the line it refers to. please put your code above this
comment, not below

+  has_scrolled_focused_editable_node_into_rect_ = false;

[jamesr, 2014/06/19 17:53:58]

it's not at all clear why this line is here. could you add a comment?

if the user rotates the screen 90' then rotates it back, shouldn't another tap
in the same editable area be ignored? they'll be back where they started

   FOR_EACH_OBSERVER(RenderViewObserver,
                     observers_,
                     OrientationChangeEvent());
 
   webview()->mainFrame()->sendOrientationChangeEvent();
 }
 
 void RenderViewImpl::OnPluginActionAt(const gfx::Point& location,
                                       const WebPluginAction& action) {
   if (webview())
@@ skipping 1115 matching lines @@
     std::vector<gfx::Size> sizes;
     ConvertToFaviconSizes(icon_urls[i].sizes(), &sizes);
     if (!url.isEmpty())
       urls.push_back(
           FaviconURL(url, ToFaviconType(icon_urls[i].iconType()), sizes));
   }
   SendUpdateFaviconURL(urls);
 }
 
 }  // namespace content