Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2687373002: Revert of [arm64] A shift of 0 is not allowed in ubfx. (Closed)

Created:
3 years, 10 months ago by rmcilroy
Modified:
3 years, 10 months ago
Reviewers:
Benedikt Meurer, v8-arm-ports, martyn.capewell, ahaas
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [arm64] A shift of 0 is not allowed in ubfx. (patchset #2 id:20001 of https://codereview.chromium.org/2685943003/ ) Reason for revert: Reverting due to causing Word64AndWithImmediateWithWord64Sh to fail locally (but not on the bot). BUG=v8:5956 Original issue's description: > [arm64] A shift of 0 is not allowed in ubfx. > > R=bmeurer@chromium.org, v8-arm-ports@googlegroups.com > BUG=v8:5951 > > Review-Url: https://codereview.chromium.org/2685943003 > Cr-Commit-Position: refs/heads/master@{#43090} > Committed: https://chromium.googlesource.com/v8/v8/+/c46ccef921ee754d60283d132b9d19f64ae7b1ff TBR=bmeurer@chromium.org,v8-arm-ports@googlegroups.com,martyn.capewell@arm.com,ahaas@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5951 Review-Url: https://codereview.chromium.org/2687373002 Cr-Commit-Position: refs/heads/master@{#43105} Committed: https://chromium.googlesource.com/v8/v8/+/e8422597a859e9e9964f30373037d0f8eefd965b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -21 lines) Patch
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +11 lines, -13 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
rmcilroy
Created Revert of [arm64] A shift of 0 is not allowed in ubfx.
3 years, 10 months ago (2017-02-10 14:54:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2687373002/1
3 years, 10 months ago (2017-02-10 14:54:20 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 14:54:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/e8422597a859e9e9964f30373037d0f8eef...

Powered by Google App Engine
This is Rietveld 408576698