[arm64] A shift of 0 is not allowed in ubfx.

[arm64] A shift of 0 is not allowed in ubfx.

R=bmeurer@chromium.org, v8-arm-ports@googlegroups.com
BUG=v8:5951
Review-Url: https://codereview.chromium.org/2685943003
Cr-Original-Commit-Position: refs/heads/master@{#43090}
Committed: https://chromium.googlesource.com/v8/v8/+/c46ccef921ee754d60283d132b9d19f64ae7b1ff
Review-Url: https://codereview.chromium.org/2685943003
Cr-Commit-Position: refs/heads/master@{#43199}
Committed: https://chromium.googlesource.com/v8/v8/+/2f8ad11f2bf35e0e63b30337a5b4966839ed14c9

[ahaas, 2017-02-09 15:53:00]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 15:53:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 16:37:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 16:37:01]

Dry run: Try jobs failed on following builders:
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/20709)
  v8_linux64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng_triggered...)

[martyn.capewell, 2017-02-09 18:21:29]

martyn.capewell@arm.com changed reviewers:
+ martyn.capewell@arm.com

[martyn.capewell, 2017-02-09 18:21:29]

lgtm

[ahaas, 2017-02-10 09:06:21]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 09:06:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 09:44:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 09:44:34]

Dry run: This issue passed the CQ dry run.

[ahaas, 2017-02-10 09:58:08]

The CQ bit was checked by ahaas@chromium.org

[ahaas, 2017-02-10 09:58:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
martyn.capewell@arm.com
Link to the patchset: https://codereview.chromium.org/2685943003/#ps20001
(title: "Make input type explicit")

[commit-bot: I haz the power, 2017-02-10 09:58:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 10:01:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 10:01:23]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/34437)

[Benedikt Meurer, 2017-02-10 10:14:01]

lgtm

[ahaas, 2017-02-10 10:14:41]

The CQ bit was checked by ahaas@chromium.org

[commit-bot: I haz the power, 2017-02-10 10:14:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 10:16:30]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486721681972350,
"parent_rev": "1fc93f2e2d33aaa0424901d0187a2548bc5051fc", "commit_rev":
"c46ccef921ee754d60283d132b9d19f64ae7b1ff"}

[commit-bot: I haz the power, 2017-02-10 10:16:35]

Description was changed from

==========
[arm64] A shift of 0 is not allowed in ubfx.

R=bmeurer@chromium.org, v8-arm-ports@googlegroups.com
BUG=v8:5951
==========

to

==========
[arm64] A shift of 0 is not allowed in ubfx.

R=bmeurer@chromium.org, v8-arm-ports@googlegroups.com
BUG=v8:5951

Review-Url: https://codereview.chromium.org/2685943003
Cr-Commit-Position: refs/heads/master@{#43090}
Committed:
https://chromium.googlesource.com/v8/v8/+/c46ccef921ee754d60283d132b9d19f64ae...
==========

[commit-bot: I haz the power, 2017-02-10 10:16:38]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/c46ccef921ee754d60283d132b9d19f64ae...

[rmcilroy, 2017-02-10 14:54:12]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2687373002/ by rmcilroy@chromium.org.

The reason for reverting is: Reverting due to causing
Word64AndWithImmediateWithWord64Sh to fail locally (but not on the bot).

BUG=v8:5956.

[ahaas, 2017-02-13 09:11:09]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 09:11:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ahaas, 2017-02-13 09:17:54]

On 2017/02/10 at 14:54:12, rmcilroy wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2687373002/ by rmcilroy@chromium.org.
> 
> The reason for reverting is: Reverting due to causing
Word64AndWithImmediateWithWord64Sh to fail locally (but not on the bot).
> 
> BUG=v8:5956.

PTAL: After looking at Word64AndWithImmediateWithWord64Shr I think it is more
appropriate to check that mask_width != 64 than to check that lsb != 0. The
reason is that the unittest contains a test with lsb == 0, but it does not
contain a test with mask_width = 64.

[commit-bot: I haz the power, 2017-02-13 09:33:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 09:33:43]

Dry run: This issue passed the CQ dry run.

[martyn.capewell, 2017-02-14 16:49:20]

lgtm

[ahaas, 2017-02-14 17:17:59]

The CQ bit was checked by ahaas@chromium.org

[ahaas, 2017-02-14 17:17:59]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/2685943003/#ps40001
(title: "New fix")

[commit-bot: I haz the power, 2017-02-14 17:18:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 17:40:52]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487092679020490,
"parent_rev": "94ac7850c451022d56728707c3c08748ec6e0af9", "commit_rev":
"2f8ad11f2bf35e0e63b30337a5b4966839ed14c9"}

[commit-bot: I haz the power, 2017-02-14 17:40:57]

Description was changed from

==========
[arm64] A shift of 0 is not allowed in ubfx.

R=bmeurer@chromium.org, v8-arm-ports@googlegroups.com
BUG=v8:5951

Review-Url: https://codereview.chromium.org/2685943003
Cr-Commit-Position: refs/heads/master@{#43090}
Committed:
https://chromium.googlesource.com/v8/v8/+/c46ccef921ee754d60283d132b9d19f64ae...
==========

to

==========
[arm64] A shift of 0 is not allowed in ubfx.

R=bmeurer@chromium.org, v8-arm-ports@googlegroups.com
BUG=v8:5951

Review-Url: https://codereview.chromium.org/2685943003
Cr-Original-Commit-Position: refs/heads/master@{#43090}
Committed:
https://chromium.googlesource.com/v8/v8/+/c46ccef921ee754d60283d132b9d19f64ae...
Review-Url: https://codereview.chromium.org/2685943003
Cr-Commit-Position: refs/heads/master@{#43199}
Committed:
https://chromium.googlesource.com/v8/v8/+/2f8ad11f2bf35e0e63b30337a5b4966839e...
==========

[commit-bot: I haz the power, 2017-02-14 17:40:58]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/2f8ad11f2bf35e0e63b30337a5b4966839e...