Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Issue 2687283002: Remove ParkThreadsScope (Closed)

Created:
3 years, 10 months ago by haraken
Modified:
3 years, 10 months ago
Reviewers:
sof
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ParkThreadsScope Now that Oilpan has a per-thread heap, it doesn't need to park any other thread. We can simply remove ParkThreadsScope. BUG=671856 Review-Url: https://codereview.chromium.org/2687283002 Cr-Commit-Position: refs/heads/master@{#449588} Committed: https://chromium.googlesource.com/chromium/src/+/75d9c7e22b281a5e22a6382b9f9a2d9a9dbeac4f

Patch Set 1 #

Patch Set 2 : temp #

Patch Set 3 : temp #

Patch Set 4 : temp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -116 lines) Patch
M third_party/WebKit/Source/platform/heap/Heap.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.cpp View 1 2 chunks +0 lines, -47 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 1 2 3 3 chunks +3 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 1 2 3 2 chunks +0 lines, -46 lines 0 comments Download

Messages

Total messages: 21 (11 generated)
haraken
PTAL I'll remove SafePointBarrier::xxx in a follow-up.
3 years, 10 months ago (2017-02-10 07:50:57 UTC) #2
sof
lgtm Can ThreadHeap::{park,resume}() be removed?
3 years, 10 months ago (2017-02-10 07:55:34 UTC) #3
haraken
> Can ThreadHeap::{park,resume}() be removed? Done. Also I noticed that there's another (unused) ParkThreadsScope in ...
3 years, 10 months ago (2017-02-10 08:02:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2687283002/20001
3 years, 10 months ago (2017-02-10 08:02:38 UTC) #7
sof
On 2017/02/10 08:02:11, haraken wrote: > > Can ThreadHeap::{park,resume}() be removed? > > Done. > ...
3 years, 10 months ago (2017-02-10 08:05:06 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/209677) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 10 months ago (2017-02-10 08:20:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2687283002/40001
3 years, 10 months ago (2017-02-10 09:13:53 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/151090) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 10 months ago (2017-02-10 09:15:27 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2687283002/60001
3 years, 10 months ago (2017-02-10 09:19:12 UTC) #18
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 11:15:51 UTC) #21
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/75d9c7e22b281a5e22a6382b9f9a...

Powered by Google App Engine
This is Rietveld 408576698