Remove ParkThreadsScope

third_party/WebKit/Source/platform/heap/HeapTest.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 260 matching lines @@
   static const bool value = IsTraceable<blink::StrongWeakPair>::value;
 };
 
 }  // namespace WTF
 
 namespace blink {
 
 class TestGCScope {
  public:
   explicit TestGCScope(BlinkGC::StackState state)
-      : m_state(ThreadState::current()),
-        m_safePointScope(state),
-        m_parkedAllThreads(false) {
+      : m_state(ThreadState::current()), m_safePointScope(state) {
     ASSERT(m_state->checkThread());
-    if (LIKELY(m_state->heap().park())) {
-      m_state->heap().preGC();
-      m_parkedAllThreads = true;
-    }
+    m_state->heap().preGC();
   }
 
-  bool allThreadsParked() { return m_parkedAllThreads; }
-
-  ~TestGCScope() {
-    // Only cleanup if we parked all threads in which case the GC happened
-    // and we need to resume the other threads.
-    if (LIKELY(m_parkedAllThreads)) {
-      m_state->heap().postGC(BlinkGC::GCWithSweep);
-      m_state->heap().resume();
-    }
-  }
+  ~TestGCScope() { m_state->heap().postGC(BlinkGC::GCWithSweep); }
 
  private:
   ThreadState* m_state;
   SafePointScope m_safePointScope;
-  bool m_parkedAllThreads;  // False if we fail to park all threads
 };
 
 class SimpleObject : public GarbageCollected<SimpleObject> {
  public:
   static SimpleObject* create() { return new SimpleObject(); }
   DEFINE_INLINE_TRACE() {}
   char getPayload(int i) { return payload[i]; }
   // This virtual method is unused but it is here to make sure
   // that this object has a vtable. This object is used
   // as the super class for objects that also have garbage
@@ skipping 3463 matching lines @@
   // causes the object start bitmap to be computed which requires the heap
   // to be in a consistent state (e.g. the free allocation area must be put
   // into a free list header). However when we call makeConsistentForGC it
   // also clears out the freelists so we have to rebuild those before trying
   // to allocate anything again. We do this by forcing a GC after doing the
   // checkAndMarkPointer tests.
   {
     TestGCScope scope(BlinkGC::HeapPointersOnStack);
     ThreadState::GCForbiddenScope gcScope(ThreadState::current());
     Visitor visitor(ThreadState::current(), Visitor::GlobalMarking);
-    EXPECT_TRUE(scope.allThreadsParked());  // Fail the test if we could not
-                                            // park all threads.
     heap.flushHeapDoesNotContainCache();
     for (size_t i = 0; i < objectAddresses.size(); i++) {
       EXPECT_TRUE(heap.checkAndMarkPointer(&visitor, objectAddresses[i],
                                            reportMarkedPointer));
       EXPECT_TRUE(heap.checkAndMarkPointer(&visitor, endAddresses[i],
                                            reportMarkedPointer));
     }
     EXPECT_EQ(objectAddresses.size() * 2, s_checkMarkCount);
     s_checkMarkCount = 0;
     EXPECT_TRUE(heap.checkAndMarkPointer(&visitor, largeObjectAddress,
                                          reportMarkedPointer));
     EXPECT_TRUE(heap.checkAndMarkPointer(&visitor, largeObjectEndAddress,
                                          reportMarkedPointer));
     EXPECT_EQ(2ul, s_checkMarkCount);
     s_checkMarkCount = 0ul;
   }
   // This forces a GC without stack scanning which results in the objects
   // being collected. This will also rebuild the above mentioned freelists,
   // however we don't rely on that below since we don't have any allocations.
   clearOutOldGarbage();
   {
     TestGCScope scope(BlinkGC::HeapPointersOnStack);
     ThreadState::GCForbiddenScope gcScope(ThreadState::current());
     Visitor visitor(ThreadState::current(), Visitor::GlobalMarking);
-    EXPECT_TRUE(scope.allThreadsParked());
     heap.flushHeapDoesNotContainCache();
     for (size_t i = 0; i < objectAddresses.size(); i++) {
       // We would like to assert that checkAndMarkPointer returned false
       // here because the pointers no longer point into a valid object
       // (it's been freed by the GCs. But checkAndMarkPointer will return
       // true for any pointer that points into a heap page, regardless of
       // whether it points at a valid object (this ensures the
       // correctness of the page-based on-heap address caches), so we
       // can't make that assert.
       heap.checkAndMarkPointer(&visitor, objectAddresses[i],
@@ skipping 2551 matching lines @@
       "HeapVector");
   static_assert(
       WTF::IsGarbageCollectedType<HeapDeque<Member<IntWrapper>>>::value,
       "HeapDeque");
   static_assert(WTF::IsGarbageCollectedType<
                     HeapTerminatedArray<Member<IntWrapper>>>::value,
                 "HeapTerminatedArray");
 }
 
 }  // namespace blink