Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2687243002: Rename the methods in EditingStyleUtilities class and make them used in editing (Closed)

Created:
3 years, 10 months ago by joone
Modified:
3 years, 10 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename the methods in EditingStyleUtilities class and make them used in editing EditingStyle is used to deal with CSS styles in editing. but it has many static methods to create an EditingStyle and some methods don't access member variables so they could be split into EditingStyleUtilities class. In the previous CLs, we just copied EditingStyle class and renamed it to EditingStyleUtilities class(https://crrev.com/2649613002). In addition, we only kept the static methods used to create an EditingStyle and some static methods for utility purpose in EditingStyleUtilities class(https://crrev.com/2685783004). This CL renames the methods in EditingStyleUtilities class and make them used in editing. The next CL will get rid of the static methods moved to EditingStyleUtilities class from EditiingStyle class. BUG=679817 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2687243002 Cr-Commit-Position: refs/heads/master@{#449554} Committed: https://chromium.googlesource.com/chromium/src/+/c39bf24ed5228e0da8b7cc1700e1cac6f4997b08

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -26 lines) Patch
M third_party/WebKit/Source/core/editing/EditingStyle.cpp View 7 chunks +14 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingStyleUtilities.h View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingStyleUtilities.cpp View 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/Editor.cpp View 3 chunks +9 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp View 3 chunks +7 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.cpp View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
joone
Hi yosin@ could you take a look at this CL?
3 years, 10 months ago (2017-02-10 05:24:53 UTC) #8
yosin_UTC9
lgtm
3 years, 10 months ago (2017-02-10 05:39:41 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2687243002/1
3 years, 10 months ago (2017-02-10 05:40:07 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 05:47:13 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c39bf24ed5228e0da8b7cc1700e1...

Powered by Google App Engine
This is Rietveld 408576698