third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp - Issue 2687243002: Rename the methods in EditingStyleUtilities class and make them used in editing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp

Issue 2687243002: Rename the methods in EditingStyleUtilities class and make them used in editing (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/Editor.cpp ('k') | third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp b/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp

index 75abe7dd9c3554cf9461c7f7d3b8100d54e1ae08..040fda0fad899edbaf0a99b19afff8920cc74c28 100644

--- a/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp

@@ -37,6 +37,7 @@

#include "core/dom/Range.h"

#include "core/dom/Text.h"

#include "core/editing/EditingStyle.h"

+#include "core/editing/EditingStyleUtilities.h"

#include "core/editing/EditingUtilities.h"

#include "core/editing/PlainTextRange.h"

#include "core/editing/VisibleUnits.h"

@@ -656,7 +657,7 @@ static HTMLElement* highestEmbeddingAncestor(Node* startNode,

Node* enclosingNode) {

for (Node* n = startNode; n && n != enclosingNode; n = n->parentNode()) {

if (n->isHTMLElement() &&

- EditingStyle::isEmbedOrIsolate(getIdentifierValue(

+ EditingStyleUtilities::isEmbedOrIsolate(getIdentifierValue(

CSSComputedStyleDeclaration::create(n), CSSPropertyUnicodeBidi))) {

return toHTMLElement(n);

}