WPT importer: Use concise lists of version specifiers in expectation lines.

WPT importer: Use concise lists of version specifiers in expectation lines.

For example, instead of adding TestExpectation lines like

 crbug.com/626703 [ Precise Trusty Mac10.11 Mac10.10 Retina Win7 Win10 Mac10.9 ] external/wpt/foo.html [ Failure ]
 crbug.com/626703 [ Precise Trusty Mac10.11 Mac10.10 Retina Mac10.9 ] external/wpt/bar.html [ Failure ]

Add lines like:

 crbug.com/626703 external/wpt/foo.html [ Failure ]
 crbug.com/626703 [ Mac ] external/wpt/bar.html [ Failure ]

Note, this change includes the change in https://codereview.chromium.org/2692063002.

BUG=655201
Review-Url: https://codereview.chromium.org/2687093005
Cr-Commit-Position: refs/heads/master@{#450264}
Committed: https://chromium.googlesource.com/chromium/src/+/14d0f71b8deb5b63f498c92ccc37a65b46536e84

[qyearsley, 2017-02-13 19:49:03]

Description was changed from

==========
WPT importer: Use concise lists of version specifiers in expectation lines (WIP)

BUG=655201
==========

to

==========
WPT importer: Use concise lists of version specifiers in expectation lines

BUG=655201
==========

[qyearsley, 2017-02-13 19:49:03]

qyearsley@chromium.org changed reviewers:
+ jeffcarp@chromium.org

[qyearsley, 2017-02-13 19:49:24]

qyearsley@chromium.org changed reviewers:
+ tkent@chromium.org

[qyearsley, 2017-02-13 19:51:01]

Description was changed from

==========
WPT importer: Use concise lists of version specifiers in expectation lines

BUG=655201
==========

to

==========
WPT importer: Use concise lists of version specifiers in expectation lines.

For example, instead of adding TestExpectation lines like

 crbug.com/626703 [ Precise Trusty Mac10.11 Mac10.10 Retina Win7 Win10 Mac10.9 ]
external/wpt/foo.html [ Failure ]
 crbug.com/626703 [ Precise Trusty Mac10.11 Mac10.10 Retina Mac10.9 ]
external/wpt/bar.html [ Failure ]

Add lines like:

 crbug.com/626703 external/wpt/foo.html [ Failure ]
 crbug.com/626703 [ Mac ] external/wpt/bar.html [ Failure ]

BUG=655201
==========

[qyearsley, 2017-02-13 19:51:38]

Description was changed from

==========
WPT importer: Use concise lists of version specifiers in expectation lines.

For example, instead of adding TestExpectation lines like

 crbug.com/626703 [ Precise Trusty Mac10.11 Mac10.10 Retina Win7 Win10 Mac10.9 ]
external/wpt/foo.html [ Failure ]
 crbug.com/626703 [ Precise Trusty Mac10.11 Mac10.10 Retina Mac10.9 ]
external/wpt/bar.html [ Failure ]

Add lines like:

 crbug.com/626703 external/wpt/foo.html [ Failure ]
 crbug.com/626703 [ Mac ] external/wpt/bar.html [ Failure ]

BUG=655201
==========

to

==========
WPT importer: Use concise lists of version specifiers in expectation lines.

For example, instead of adding TestExpectation lines like

 crbug.com/626703 [ Precise Trusty Mac10.11 Mac10.10 Retina Win7 Win10 Mac10.9 ]
external/wpt/foo.html [ Failure ]
 crbug.com/626703 [ Precise Trusty Mac10.11 Mac10.10 Retina Mac10.9 ]
external/wpt/bar.html [ Failure ]

Add lines like:

 crbug.com/626703 external/wpt/foo.html [ Failure ]
 crbug.com/626703 [ Mac ] external/wpt/bar.html [ Failure ]

Note, this change includes the change in
https://codereview.chromium.org/2692063002.

BUG=655201
==========

[qyearsley, 2017-02-13 19:51:41]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 19:52:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[qyearsley, 2017-02-13 19:54:23]

https://codereview.chromium.org/2687093005/diff/20001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py
(right):

https://codereview.chromium.org/2687093005/diff/20001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py:287:
specifiers.extend(self.skipped_specifiers(test_name))
The purpose of this is so that Android is included in the list of specifiers, so
that it can be simplified out for tests that aren't run on Android.

https://codereview.chromium.org/2687093005/diff/20001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py:342:
return sorted(specifier.capitalize() for specifier in specifiers)
This is the main part of this change.

[jeffcarp, 2017-02-13 20:42:18]

lgtm with nits

https://codereview.chromium.org/2687093005/diff/20001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py
(right):

https://codereview.chromium.org/2687093005/diff/20001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py:256:
['BUG_URL [PLATFORM(S)] TEST_MAME [EXPECTATION(S)]']
I know this isn't part of the CL but should this be TEST_NAME?

https://codereview.chromium.org/2687093005/diff/20001/third_party/WebKit/Tool...
File
third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater_unittest.py
(right):

https://codereview.chromium.org/2687093005/diff/20001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater_unittest.py:191:
self.assertEqual(updater.simplify_specifiers(['Mac10.10', 'Mac10.11', 'Trusty',
'Win7', 'Win10'], macros), [])
Can you also test the case when there are more versions than specifiers? (I'm
trying to figure out what would happen on line 337 of
wpt_expectations_updater.py if that is the case)

[commit-bot: I haz the power, 2017-02-13 20:56:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 20:56:41]

Dry run: This issue passed the CQ dry run.

[qyearsley, 2017-02-14 00:00:51]

https://codereview.chromium.org/2687093005/diff/20001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py
(right):

https://codereview.chromium.org/2687093005/diff/20001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py:256:
['BUG_URL [PLATFORM(S)] TEST_MAME [EXPECTATION(S)]']
On 2017/02/13 at 20:42:18, jeffcarp wrote:
> I know this isn't part of the CL but should this be TEST_NAME?

Yep! Unless mame has some meaning I'm not aware of...

https://codereview.chromium.org/2687093005/diff/20001/third_party/WebKit/Tool...
File
third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater_unittest.py
(right):

https://codereview.chromium.org/2687093005/diff/20001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater_unittest.py:191:
self.assertEqual(updater.simplify_specifiers(['Mac10.10', 'Mac10.11', 'Trusty',
'Win7', 'Win10'], macros), [])
On 2017/02/13 at 20:42:18, jeffcarp wrote:
> Can you also test the case when there are more versions than specifiers? (I'm
trying to figure out what would happen on line 337 of
wpt_expectations_updater.py if that is the case)

A few points which are possibly confusing:
  The "versions" are also "specifiers", and vice versa -- they're all "version
specifiers". This should be made clearer.
  The <= operator is overridden for sets, so a <= b is equivalent to
a.issubset(b) here. Maybe it would be more explicit to actually call that
method? So anyway, if the set on the left side is larger than the set on the
right side, then it's definitely not a subset, so it's false, so no change is
made to the specifier list.

[qyearsley, 2017-02-14 00:00:55]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 00:02:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 01:10:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 01:10:54]

Dry run: This issue passed the CQ dry run.

[qyearsley, 2017-02-14 05:21:34]

The CQ bit was checked by qyearsley@chromium.org

[qyearsley, 2017-02-14 05:21:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
jeffcarp@chromium.org
Link to the patchset: https://codereview.chromium.org/2687093005/#ps40001
(title: "versions->version_specifiers, accept, upper-case macros, use issubset,
mame -> name")

[commit-bot: I haz the power, 2017-02-14 05:21:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 05:26:30]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487049694575900,
"parent_rev": "33c1e1d128713823e6fcc89deaaa92d7f832bdd5", "commit_rev":
"14d0f71b8deb5b63f498c92ccc37a65b46536e84"}

[commit-bot: I haz the power, 2017-02-14 05:27:19]

Description was changed from

==========
WPT importer: Use concise lists of version specifiers in expectation lines.

For example, instead of adding TestExpectation lines like

 crbug.com/626703 [ Precise Trusty Mac10.11 Mac10.10 Retina Win7 Win10 Mac10.9 ]
external/wpt/foo.html [ Failure ]
 crbug.com/626703 [ Precise Trusty Mac10.11 Mac10.10 Retina Mac10.9 ]
external/wpt/bar.html [ Failure ]

Add lines like:

 crbug.com/626703 external/wpt/foo.html [ Failure ]
 crbug.com/626703 [ Mac ] external/wpt/bar.html [ Failure ]

Note, this change includes the change in
https://codereview.chromium.org/2692063002.

BUG=655201
==========

to

==========
WPT importer: Use concise lists of version specifiers in expectation lines.

For example, instead of adding TestExpectation lines like

 crbug.com/626703 [ Precise Trusty Mac10.11 Mac10.10 Retina Win7 Win10 Mac10.9 ]
external/wpt/foo.html [ Failure ]
 crbug.com/626703 [ Precise Trusty Mac10.11 Mac10.10 Retina Mac10.9 ]
external/wpt/bar.html [ Failure ]

Add lines like:

 crbug.com/626703 external/wpt/foo.html [ Failure ]
 crbug.com/626703 [ Mac ] external/wpt/bar.html [ Failure ]

Note, this change includes the change in
https://codereview.chromium.org/2692063002.

BUG=655201

Review-Url: https://codereview.chromium.org/2687093005
Cr-Commit-Position: refs/heads/master@{#450264}
Committed:
https://chromium.googlesource.com/chromium/src/+/14d0f71b8deb5b63f498c92ccc37...
==========

[commit-bot: I haz the power, 2017-02-14 05:27:20]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/14d0f71b8deb5b63f498c92ccc37...