third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py - Issue 2687093005: WPT importer: Use concise lists of version specifiers in expectation lines.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

Issue 2687093005: WPT importer: Use concise lists of version specifiers in expectation lines. (Closed)

Patch Set: versions->version_specifiers, accept, upper-case macros, use issubset, mame -> name Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/builder_list_unittest.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

index f27baddfc3f4780c831140a786daa97fbac7b22f..cfb9b06c59f6ea6141a4c48265e7fb8031803ca6 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

@@ -931,6 +931,7 @@ class Port(object):

return tests_to_skip

def _expectations_from_skipped_files(self, skipped_file_paths):

+ # TODO(qyearsley): Remove this if there are no more "Skipped" files.

tests_to_skip = []

for search_path in skipped_file_paths:

filename = self._filesystem.join(self._absolute_baseline_path(search_path), "Skipped")