Rename GLImageOzoneNativePixmap to GLImageNativePixmap and move it from ui/ozone/gl to ui/gl

Rename GLImageOzoneNativePixmap to GLImageNativePixmap and move it from ui/ozone/gl to ui/gl

This enable gl::GLImageEGL with EGL_LINUX_DMA_BUF_EXT on linux
desktop. This code was not specific to ozone and available on
any standard linux platforms.

BUG=584248
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2687093002
Cr-Commit-Position: refs/heads/master@{#454624}
Committed: https://chromium.googlesource.com/chromium/src/+/25e34786aca737cf84b1b1d59c5051bdc88cb045

[Julien Isorce, 2017-02-09 12:13:11]

Description was changed from

==========
Rename GLImageOzoneNativePixmap to GLImageNativePixmap and move it from
ui/ozone/gl to ui/gl

This enable gl::GLImageEGL with EGL_LINUX_DMA_BUF_EXT on linux
desktop. This code was not specific to ozone and available on
any standard linux platforms.

BUG=584248
R=reveman@chromium.org
==========

to

==========
Rename GLImageOzoneNativePixmap to GLImageNativePixmap and move it from
ui/ozone/gl to ui/gl

This enable gl::GLImageEGL with EGL_LINUX_DMA_BUF_EXT on linux
desktop. This code was not specific to ozone and available on
any standard linux platforms.

BUG=584248
R=reveman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Julien Isorce, 2017-02-21 17:00:39]

PTAL.

[reveman, 2017-02-23 03:25:59]

lgtm

would be nice to move the dmabuf case into a separate GLImage impl but not
needed for this CL. Btw, are we even using the non dmabuf case?

[Julien Isorce, 2017-02-23 13:51:01]

On 2017/02/23 03:25:59, reveman wrote:
> lgtm
> 
> would be nice to move the dmabuf case into a separate GLImage impl but not
> needed for this CL. 

Thx for the review. All right I can do that in a future CL.

> Btw, are we even using the non dmabuf case?

It seems that pixmap->GetEGLClientBuffer is not used since commit a28fd14b7 . I
might be wrong but it looks to me that this was all designed for
EGL_NATIVE_PIXMAP_KHR and then it has been superseeded by EGL_LINUX_DMA_BUF_EXT.

I think I will finish the ozone agnostic work first. Which is mostly about
removing the name ozone and moving out of ozone directory. Later on I can adapt
all of this to follow  EGL_LINUX_DMA_BUF_EXT naming rather than
EGL_NATIVE_PIXMAP_KHR.

[Julien Isorce, 2017-02-23 13:53:50]

Description was changed from

==========
Rename GLImageOzoneNativePixmap to GLImageNativePixmap and move it from
ui/ozone/gl to ui/gl

This enable gl::GLImageEGL with EGL_LINUX_DMA_BUF_EXT on linux
desktop. This code was not specific to ozone and available on
any standard linux platforms.

BUG=584248
R=reveman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Rename GLImageOzoneNativePixmap to GLImageNativePixmap and move it from
ui/ozone/gl to ui/gl

This enable gl::GLImageEGL with EGL_LINUX_DMA_BUF_EXT on linux
desktop. This code was not specific to ozone and available on
any standard linux platforms.

BUG=584248
R=dnicoara@chromium.org, reveman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Julien Isorce, 2017-02-23 13:53:51]

julien.isorce@chromium.org changed reviewers:
+ dnicoara@chromium.org

[Julien Isorce, 2017-02-23 13:54:00]

The CQ bit was checked by julien.isorce@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 13:54:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 15:38:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 15:38:01]

Dry run: This issue passed the CQ dry run.

[dnicoara, 2017-02-23 16:07:02]

dnicoara@chromium.org changed reviewers:
+ rjkroege@chromium.org

[dnicoara, 2017-02-23 16:07:03]

lgtm

+ rjkroege@ for broader Ozone owner review

[spang, 2017-02-23 18:27:18]

spang@chromium.org changed reviewers:
+ spang@chromium.org

[spang, 2017-02-23 18:27:18]

lgtm

[rjkroege, 2017-02-24 03:32:57]

lgtm

[Julien Isorce, 2017-02-24 10:31:27]

julien.isorce@chromium.org changed reviewers:
+ sandersd@chromium.org

[Julien Isorce, 2017-02-24 10:32:35]

On 2017/02/24 03:32:57, rjkroege (slow) wrote:
> lgtm

Thx for the reviews.

And + sandersd@ for media/gpu.

[sandersd (OOO until July 31), 2017-02-24 21:09:47]

media/ lgtm.

[Julien Isorce, 2017-03-03 15:29:10]

The CQ bit was checked by julien.isorce@chromium.org

[Julien Isorce, 2017-03-03 15:29:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
reveman@chromium.org, rjkroege@chromium.org, dnicoara@chromium.org,
spang@chromium.org, sandersd@chromium.org
Link to the patchset: https://codereview.chromium.org/2687093002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-03 15:29:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 15:35:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 15:35:36]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Julien Isorce, 2017-03-03 15:42:18]

Description was changed from

==========
Rename GLImageOzoneNativePixmap to GLImageNativePixmap and move it from
ui/ozone/gl to ui/gl

This enable gl::GLImageEGL with EGL_LINUX_DMA_BUF_EXT on linux
desktop. This code was not specific to ozone and available on
any standard linux platforms.

BUG=584248
R=dnicoara@chromium.org, reveman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Rename GLImageOzoneNativePixmap to GLImageNativePixmap and move it from
ui/ozone/gl to ui/gl

This enable gl::GLImageEGL with EGL_LINUX_DMA_BUF_EXT on linux
desktop. This code was not specific to ozone and available on
any standard linux platforms.

BUG=584248
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Julien Isorce, 2017-03-03 15:42:18]

julien.isorce@chromium.org changed reviewers:
+ sadrul@chromium.org

[Julien Isorce, 2017-03-03 15:42:42]

On 2017/03/03 15:35:36, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    ui/gl/BUILD.gn

Hi sadrul@ , please take a look. Thx!

[sadrul, 2017-03-03 15:44:17]

lgtm

[Julien Isorce, 2017-03-03 15:45:02]

The CQ bit was checked by julien.isorce@chromium.org

[commit-bot: I haz the power, 2017-03-03 15:45:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 18:19:39]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488555902634620,
"parent_rev": "9cef0dfbd1deadc0f89e6ec7efb13309e7cea565", "commit_rev":
"25e34786aca737cf84b1b1d59c5051bdc88cb045"}

[commit-bot: I haz the power, 2017-03-03 18:20:18]

Description was changed from

==========
Rename GLImageOzoneNativePixmap to GLImageNativePixmap and move it from
ui/ozone/gl to ui/gl

This enable gl::GLImageEGL with EGL_LINUX_DMA_BUF_EXT on linux
desktop. This code was not specific to ozone and available on
any standard linux platforms.

BUG=584248
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Rename GLImageOzoneNativePixmap to GLImageNativePixmap and move it from
ui/ozone/gl to ui/gl

This enable gl::GLImageEGL with EGL_LINUX_DMA_BUF_EXT on linux
desktop. This code was not specific to ozone and available on
any standard linux platforms.

BUG=584248
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2687093002
Cr-Commit-Position: refs/heads/master@{#454624}
Committed:
https://chromium.googlesource.com/chromium/src/+/25e34786aca737cf84b1b1d59c50...
==========

[commit-bot: I haz the power, 2017-03-03 18:20:20]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/25e34786aca737cf84b1b1d59c50...

[Julien Isorce, 2017-03-22 17:33:52]

https://codereview.chromium.org/2687093002/diff/40001/ui/gl/gl_image_native_p...
File ui/gl/gl_image_native_pixmap.h (left):

https://codereview.chromium.org/2687093002/diff/40001/ui/gl/gl_image_native_p...
ui/gl/gl_image_native_pixmap.h:17: namespace ui {
sadrul@, should I change namespace from ui to gl here ?

[sadrul, 2017-03-22 17:35:11]

https://codereview.chromium.org/2687093002/diff/40001/ui/gl/gl_image_native_p...
File ui/gl/gl_image_native_pixmap.h (left):

https://codereview.chromium.org/2687093002/diff/40001/ui/gl/gl_image_native_p...
ui/gl/gl_image_native_pixmap.h:17: namespace ui {
On 2017/03/22 17:33:52, Julien Isorce wrote:
> sadrul@, should I change namespace from ui to gl here ?

Yes please.