Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 2687083003: Fix gen-postmortem-metadata.py after r43075 (Closed)

Created:
3 years, 10 months ago by Jakob Kummerow
Modified:
3 years, 10 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix gen-postmortem-metadata.py after r43075 DescriptorArray::kDescriptorFoo was renamed to DescriptorArray::kEntryFooIndex in https://codereview.chromium.org/2688573003 TBR=ishell@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2687083003 Cr-Commit-Position: refs/heads/master@{#43076} Committed: https://chromium.googlesource.com/v8/v8/+/53a74a6446b0b2961af4ea42bcd7ad6586b35b00

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M tools/gen-postmortem-metadata.py View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
Jakob Kummerow
Fixing the nodejs-integration bot: https://build.chromium.org/p/client.v8.fyi/builders/V8%20-%20node.js%20integration/builds/3727/ NOTRY because we don't have try bot coverage for this ...
3 years, 10 months ago (2017-02-09 23:39:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2687083003/1
3 years, 10 months ago (2017-02-09 23:40:26 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 23:42:28 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/53a74a6446b0b2961af4ea42bcd7ad6586b...

Powered by Google App Engine
This is Rietveld 408576698