[cleanup] CSA: add helpers for accessing details/value via key_index

[cleanup] CSA: add helpers for accessing details/value via key_index

TBR=hpayer@chromium.org

Review-Url: https://codereview.chromium.org/2688573003
Cr-Commit-Position: refs/heads/master@{#43075}
Committed: https://chromium.googlesource.com/v8/v8/+/1fae6c339a09b45fa3fde7749e46f0a20ef9b7d9

[Jakob Kummerow, 2017-02-09 00:25:28]

jkummerow@chromium.org changed reviewers:
+ ishell@chromium.org

[Jakob Kummerow, 2017-02-09 00:25:28]

Taking care of an old TODO. PTAL.

[Jakob Kummerow, 2017-02-09 00:40:02]

The CQ bit was checked by jkummerow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 00:40:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 00:44:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 00:44:19]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/20655)
  v8_linux64_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_verify_csa_rel_n...)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)

[Jakob Kummerow, 2017-02-09 01:32:22]

The CQ bit was checked by jkummerow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 01:32:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 01:58:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 01:58:55]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2017-02-09 09:14:09]

Nice! lgtm

https://codereview.chromium.org/2688573003/diff/20001/src/code-stub-assembler.cc
File src/code-stub-assembler.cc (right):

https://codereview.chromium.org/2688573003/diff/20001/src/code-stub-assembler...
src/code-stub-assembler.cc:4422: Node*
CodeStubAssembler::LoadDetailsForKeyIndex(Node* container,
WDYT about s/For/By/ here and below?

I'd just inline these one-liners into the header to avoid explicit template
instantiations.

[Jakob Kummerow, 2017-02-09 22:20:39]

Description was changed from

==========
[cleanup] CSA: add helpers for accessing details/value via key_index
==========

to

==========
[cleanup] CSA: add helpers for accessing details/value via key_index

TBR=hpayer@chromium.org
==========

[Jakob Kummerow, 2017-02-09 22:21:28]

Thanks for the review. Addressed comments, landing.

TBR=hpayer for trivial renaming in mark-compact.cc.

https://codereview.chromium.org/2688573003/diff/20001/src/code-stub-assembler.cc
File src/code-stub-assembler.cc (right):

https://codereview.chromium.org/2688573003/diff/20001/src/code-stub-assembler...
src/code-stub-assembler.cc:4422: Node*
CodeStubAssembler::LoadDetailsForKeyIndex(Node* container,
On 2017/02/09 09:14:09, Igor Sheludko wrote:
> WDYT about s/For/By/ here and below?

Done.

> I'd just inline these one-liners into the header to avoid explicit template
> instantiations.

Done.

[Jakob Kummerow, 2017-02-09 22:21:34]

The CQ bit was checked by jkummerow@chromium.org

[Jakob Kummerow, 2017-02-09 22:21:34]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org
Link to the patchset: https://codereview.chromium.org/2688573003/#ps60001
(title: "rebased")

[commit-bot: I haz the power, 2017-02-09 22:21:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 22:51:35]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486678894175160,
"parent_rev": "81239354c32920d93c19faf0a3d0461f3f7e0f4f", "commit_rev":
"1fae6c339a09b45fa3fde7749e46f0a20ef9b7d9"}

[commit-bot: I haz the power, 2017-02-09 22:51:40]

Description was changed from

==========
[cleanup] CSA: add helpers for accessing details/value via key_index

TBR=hpayer@chromium.org
==========

to

==========
[cleanup] CSA: add helpers for accessing details/value via key_index

TBR=hpayer@chromium.org

Review-Url: https://codereview.chromium.org/2688573003
Cr-Commit-Position: refs/heads/master@{#43075}
Committed:
https://chromium.googlesource.com/v8/v8/+/1fae6c339a09b45fa3fde7749e46f0a20ef...
==========

[commit-bot: I haz the power, 2017-02-09 22:51:41]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/1fae6c339a09b45fa3fde7749e46f0a20ef...