Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2687033004:
[WebPayments] Enabling PaymentRequest on Mac (Closed)
|
Created:
3 years, 10 months ago by tmartino Modified:
3 years, 10 months ago Reviewers:
please use gerrit instead CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionEnabling PaymentRequest on Mac.
BUG=679127
Review-Url: https://codereview.chromium.org/2687033004
Cr-Commit-Position: refs/heads/master@{#449692}
Committed: https://chromium.googlesource.com/chromium/src/+/fb34188f3672ba0ce949749aaa985bdf39fc09aa
Patch Set 1 #Patch Set 2 : Rebase #Patch Set 3 : Missing deps #Patch Set 4 : Changing ifdef #Patch Set 5 : elif fail #
Total comments: 5
Patch Set 6 : grouping deps with sources #
Messages
Total messages: 36 (27 generated)
The CQ bit was checked by tmartino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by tmartino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by tmartino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Enabling PaymentRequest on Mac. BUG= ========== to ========== Enabling PaymentRequest on Mac. BUG=679127 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by tmartino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
tmartino@chromium.org changed reviewers: + rouslan@chromium.org
The CQ bit was checked by tmartino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2687033004/diff/80001/chrome/browser/ui/BUILD.gn File chrome/browser/ui/BUILD.gn (left): https://codereview.chromium.org/2687033004/diff/80001/chrome/browser/ui/BUILD... chrome/browser/ui/BUILD.gn:1826: "views/payments/view_stack.h", These files are included if "mac_views_browser" is true, so moving these lines is not necessary, right? https://codereview.chromium.org/2687033004/diff/80001/chrome/browser/ui/BUILD.gn File chrome/browser/ui/BUILD.gn (right): https://codereview.chromium.org/2687033004/diff/80001/chrome/browser/ui/BUILD... chrome/browser/ui/BUILD.gn:2145: if (is_win || is_linux || is_mac) { Does Chrome OS fall under is_linux umbrella here?
https://codereview.chromium.org/2687033004/diff/80001/chrome/browser/ui/BUILD.gn File chrome/browser/ui/BUILD.gn (left): https://codereview.chromium.org/2687033004/diff/80001/chrome/browser/ui/BUILD... chrome/browser/ui/BUILD.gn:1826: "views/payments/view_stack.h", On 2017/02/10 at 16:40:27, rouslan wrote: > These files are included if "mac_views_browser" is true, so moving these lines is not necessary, right? No, mac_views_browser is currently false. That's basically the last step of the MacViews rollout, and it's not a dependency for PaymentRequest. https://codereview.chromium.org/2687033004/diff/80001/chrome/browser/ui/BUILD.gn File chrome/browser/ui/BUILD.gn (right): https://codereview.chromium.org/2687033004/diff/80001/chrome/browser/ui/BUILD... chrome/browser/ui/BUILD.gn:2145: if (is_win || is_linux || is_mac) { On 2017/02/10 at 16:40:27, rouslan wrote: > Does Chrome OS fall under is_linux umbrella here? Yes. https://cs.chromium.org/chromium/src/build/config/BUILDCONFIG.gn?type=cs&l=271 FYI is_desktop_linux checks for strictly non-CrOS, non-Android Linux.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm % comment https://codereview.chromium.org/2687033004/diff/80001/chrome/browser/ui/BUILD.gn File chrome/browser/ui/BUILD.gn (right): https://codereview.chromium.org/2687033004/diff/80001/chrome/browser/ui/BUILD... chrome/browser/ui/BUILD.gn:2145: if (is_win || is_linux || is_mac) { Perhaps this should be !is_android instead.
The CQ bit was checked by tmartino@chromium.org to run a CQ dry run
On 2017/02/10 at 17:45:09, rouslan wrote: > lgtm % comment > > https://codereview.chromium.org/2687033004/diff/80001/chrome/browser/ui/BUILD.gn > File chrome/browser/ui/BUILD.gn (right): > > https://codereview.chromium.org/2687033004/diff/80001/chrome/browser/ui/BUILD... > chrome/browser/ui/BUILD.gn:2145: if (is_win || is_linux || is_mac) { > Perhaps this should be !is_android instead. Better still, we can just group the deps in the same if-block as the sources.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
still lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by tmartino@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/02/10 19:26:03, commit-bot: I haz the power wrote: > CQ is trying da patch. Follow status at > > https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... Could you update the tests if needed: https://cs.chromium.org/chromium/src/chrome/test/BUILD.gn?rcl=6299b9132aab1f5... https://cs.chromium.org/chromium/src/chrome/test/BUILD.gn?rcl=6299b9132aab1f5...
CQ is committing da patch.
Bot data: {"patchset_id": 100001, "attempt_start_ts": 1486754701929380,
"parent_rev": "36eee2d8b1c6cb707df5a84c6d347c863596dd5a", "commit_rev":
"fb34188f3672ba0ce949749aaa985bdf39fc09aa"}
Message was sent while issue was closed.
Description was changed from ========== Enabling PaymentRequest on Mac. BUG=679127 ========== to ========== Enabling PaymentRequest on Mac. BUG=679127 Review-Url: https://codereview.chromium.org/2687033004 Cr-Commit-Position: refs/heads/master@{#449692} Committed: https://chromium.googlesource.com/chromium/src/+/fb34188f3672ba0ce949749aaa98... ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as https://chromium.googlesource.com/chromium/src/+/fb34188f3672ba0ce949749aaa98... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
