[WebPayments] Enabling PaymentRequest on Mac

chrome/browser/ui/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/chromecast_build.gni")
 import("//build/config/crypto.gni")
 import("//build/config/features.gni")
 import("//build/config/ui.gni")
 import("//build/split_static_library.gni")
 import("//chrome/common/features.gni")
@@ skipping 1500 matching lines @@
       "views/harmony/layout_delegate.h",
       "views/layout_utils.cc",
       "views/layout_utils.h",
       "views/location_bar/location_bar_bubble_delegate_view.cc",
       "views/location_bar/location_bar_bubble_delegate_view.h",
       "views/login_handler_views.cc",
       "views/login_view.cc",
       "views/login_view.h",
       "views/new_back_shortcut_bubble.cc",
       "views/new_back_shortcut_bubble.h",
+      "views/payments/credit_card_editor_view_controller.cc",
+      "views/payments/credit_card_editor_view_controller.h",
+      "views/payments/editor_view_controller.cc",
+      "views/payments/editor_view_controller.h",
+      "views/payments/order_summary_view_controller.cc",
+      "views/payments/order_summary_view_controller.h",
+      "views/payments/payment_method_view_controller.cc",
+      "views/payments/payment_method_view_controller.h",
+      "views/payments/payment_request_dialog_view.cc",
+      "views/payments/payment_request_dialog_view.h",
+      "views/payments/payment_request_dialog_view_ids.h",
+      "views/payments/payment_request_row_view.cc",
+      "views/payments/payment_request_row_view.h",
+      "views/payments/payment_request_sheet_controller.cc",
+      "views/payments/payment_request_sheet_controller.h",
+      "views/payments/payment_request_views_util.cc",
+      "views/payments/payment_request_views_util.h",
+      "views/payments/payment_sheet_view_controller.cc",
+      "views/payments/payment_sheet_view_controller.h",
+      "views/payments/shipping_list_view_controller.cc",
+      "views/payments/shipping_list_view_controller.h",
+      "views/payments/validating_textfield.cc",
+      "views/payments/validating_textfield.h",
+      "views/payments/view_stack.cc",
+      "views/payments/view_stack.h",
       "views/subtle_notification_view.cc",
       "views/subtle_notification_view.h",
       "views/sync/bubble_sync_promo_view.cc",
       "views/sync/bubble_sync_promo_view.h",
       "views/task_manager_view.cc",
       "views/task_manager_view.h",
       "views/update_recommended_message_box.cc",
       "views/update_recommended_message_box.h",
       "views/website_settings/chosen_object_row.cc",
       "views/website_settings/chosen_object_row.h",
@@ skipping 261 matching lines @@
         "views/passwords/credentials_item_view.cc",
         "views/passwords/credentials_item_view.h",
         "views/passwords/credentials_selection_view.cc",
         "views/passwords/credentials_selection_view.h",
         "views/passwords/manage_password_items_view.cc",
         "views/passwords/manage_password_items_view.h",
         "views/passwords/manage_passwords_bubble_view.cc",
         "views/passwords/manage_passwords_bubble_view.h",
         "views/passwords/manage_passwords_icon_views.cc",
         "views/passwords/manage_passwords_icon_views.h",
-        "views/payments/credit_card_editor_view_controller.cc",
-        "views/payments/credit_card_editor_view_controller.h",
-        "views/payments/editor_view_controller.cc",
-        "views/payments/editor_view_controller.h",
-        "views/payments/order_summary_view_controller.cc",
-        "views/payments/order_summary_view_controller.h",
-        "views/payments/payment_method_view_controller.cc",
-        "views/payments/payment_method_view_controller.h",
-        "views/payments/payment_request_dialog_view.cc",
-        "views/payments/payment_request_dialog_view.h",
-        "views/payments/payment_request_dialog_view_ids.h",
-        "views/payments/payment_request_row_view.cc",
-        "views/payments/payment_request_row_view.h",
-        "views/payments/payment_request_sheet_controller.cc",
-        "views/payments/payment_request_sheet_controller.h",
-        "views/payments/payment_request_views_util.cc",
-        "views/payments/payment_request_views_util.h",
-        "views/payments/payment_sheet_view_controller.cc",
-        "views/payments/payment_sheet_view_controller.h",
-        "views/payments/shipping_list_view_controller.cc",
-        "views/payments/shipping_list_view_controller.h",
-        "views/payments/validating_textfield.cc",
-        "views/payments/validating_textfield.h",
-        "views/payments/view_stack.cc",
-        "views/payments/view_stack.h",

[please use gerrit instead, 2017/02/10 16:40:27]

These files are included if "mac_views_browser" is true, so moving these lines
is not necessary, right?

[tmartino, 2017/02/10 17:41:16]

No, mac_views_browser is currently false. That's basically the last step of the
MacViews rollout, and it's not a dependency for PaymentRequest.

         "views/process_singleton_dialog_linux.cc",
         "views/profiles/profile_indicator_icon.cc",
         "views/profiles/profile_indicator_icon.h",
         "views/profiles/signin_view_controller_delegate_views.cc",
         "views/profiles/signin_view_controller_delegate_views.h",
         "views/profiles/user_manager_view.cc",
         "views/profiles/user_manager_view.h",
         "views/proximity_auth/proximity_auth_error_bubble_view.cc",
         "views/proximity_auth/proximity_auth_error_bubble_view.h",
         "views/session_crashed_bubble_view.cc",
@@ skipping 298 matching lines @@
       "webui/settings/certificates_handler.cc",
       "webui/settings/certificates_handler.h",
     ]
   }
   if (is_mac || is_win) {
     sources += [
       "webui/settings/native_certificates_handler.cc",
       "webui/settings/native_certificates_handler.h",
     ]
   }
-  if (is_win || is_linux) {
+  if (is_win || is_linux || is_mac) {

[please use gerrit instead, 2017/02/10 16:40:27]

Does Chrome OS fall under is_linux umbrella here?

[tmartino, 2017/02/10 17:41:16]

Yes.

https://cs.chromium.org/chromium/src/build/config/BUILDCONFIG.gn?type=cs&l=271

FYI is_desktop_linux checks for strictly non-CrOS, non-Android Linux.

[please use gerrit instead, 2017/02/10 17:45:08]

Perhaps this should be !is_android instead.

     deps += [
       "//components/payments:payment_request_impl",
       "//components/payments:payment_validation",
     ]
   }
   if (enable_print_preview) {
     sources += [
       "webui/print_preview/extension_printer_handler.cc",
       "webui/print_preview/extension_printer_handler.h",
       "webui/print_preview/print_preview_handler.cc",
@@ skipping 1365 matching lines @@
       "test/test_confirm_bubble_model.cc",
       "test/test_confirm_bubble_model.h",
     ]
     deps += [ "//chrome/test:test_support_ui" ]
   }
 
   if (enable_extensions) {
     deps += [ "//extensions/browser" ]
   }
 }