Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2686863003: [MD settings] prevent scrolling contents due to floating point noise (Closed)

Created:
3 years, 10 months ago by dschuyler
Modified:
3 years, 10 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] prevent scrolling contents due to floating point noise This CL rounds up a floating point value to avoid a slow automatic scrolling in the md-settings. BUG=688947 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2686863003 Cr-Commit-Position: refs/heads/master@{#449378} Committed: https://chromium.googlesource.com/chromium/src/+/860ef963e7ecec486cce0690a1907581a9d1e581

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/resources/settings/settings_main/settings_main.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
dschuyler
This is hard to repro, if you can patch it in a try it locally ...
3 years, 10 months ago (2017-02-09 02:26:59 UTC) #5
stevenjb
I'm bouncing between several branches right now, but this certainly seems harmless at worst, so ...
3 years, 10 months ago (2017-02-09 03:03:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2686863003/1
3 years, 10 months ago (2017-02-09 19:42:31 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 19:49:03 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/860ef963e7ecec486cce0690a190...

Powered by Google App Engine
This is Rietveld 408576698