chrome/browser/resources/settings/settings_main/settings_main.js - Issue 2686863003: [MD settings] prevent scrolling contents due to floating point noise

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_main/settings_main.js

Issue 2686863003: [MD settings] prevent scrolling contents due to floating point noise (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/settings/settings_main/settings_main.js

diff --git a/chrome/browser/resources/settings/settings_main/settings_main.js b/chrome/browser/resources/settings/settings_main/settings_main.js

index 51bb5f422fb7db5c411e7c39dc236072f6f8e1db..22b4bd86fb2766ef7145bfac11d076b95fbf0639 100644

--- a/chrome/browser/resources/settings/settings_main/settings_main.js

+++ b/chrome/browser/resources/settings/settings_main/settings_main.js

@@ -124,7 +124,8 @@ Polymer({

// How much of the overscroll is visible (may be negative).

var visibleOverscroll = overscroll.scrollHeight -

(overscrollBottom - visibleBottom);

- this.overscroll_ = Math.max(opt_minHeight || 0, visibleOverscroll);

+ this.overscroll_ =

+ Math.max(opt_minHeight || 0, Math.ceil(visibleOverscroll));

/**

« no previous file with comments | « no previous file | no next file » | no next file with comments »