Revert of [Omaha] Make the whole pipeline run each time (patchset #4 id:60001 of https://codereview…

Revert of [Omaha] Make the whole pipeline run each time (patchset #4 id:60001 of https://codereview.chromium.org/2665133005/ )

Reason for revert:
Causes crashes on startup in some cases.

Original issue's description:
> [Omaha] Make the whole pipeline run each time
>
> * Instead of making OmahaClient run as an IntentService that handles individual
>   actions, run the whole pipeline, including registering new requests and
>   POSTing to the server.  This has several advantages, including that the
>   pipeline is somewhat easier to understand.
>
> * The pipeline now uses one single-shot alarm to determine when to either
>   generate a new active user request or to trigger a POST.  This requires
>   canceling existing repeating alarms.
>
> * Redoes the "isOverude" check in handleRegisterActiveRequest to just check
>   current timestamps instead of also checking that a request doesn't exist.
>   This is more logical for an "isOverdue" check, and prevents the OmahaClient
>   from trying to reschedule itself repeatedly until an existing request's
>   timestamps are screwed up.  This should be alright because the request
>   timestamp and the timestamp for the new request should match in all cases
>   where the SharedPrerences are valid.
>
> * Introduces the OmahaDelegate, which masks out calls to various classes that
>   OmahaClient requires.
>
> * Replaces all old OmahaClientTests that tested the old pipeline with one that
>   is more black-boxy and tests the new pipeline.  Significant cleanups are still
>   required here, but the pipeline will be changing further and basic tests are
>   better than no tests.
>
> BUG=680817
>
> Review-Url: https://codereview.chromium.org/2665133005
> Cr-Commit-Position: refs/heads/master@{#448803}
> Committed: https://chromium.googlesource.com/chromium/src/+/c9625f069b73578ab45f49be70a830d48f6141bc

TBR=dfalcantara@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=680817, 690054, 689850, 689894
Review-Url: https://codereview.chromium.org/2685053002
Cr-Commit-Position: refs/heads/master@{#449127}
(cherry picked from commit 0e1252cce0bae1c59bfd1c1c998f8206258b3123)

Review-Url: https://codereview.chromium.org/2686783003 .
Cr-Commit-Position: refs/branch-heads/3006@{#3}
Cr-Branched-From: d6822b0656d0a9a13ca7926806e22b3afa4d2bf9-refs/heads/master@{#448862}
Committed: https://chromium.googlesource.com/chromium/src/+/d92b8f8279b057dee4285b668ec1ade6d52af68e

[nyquist, 2017-02-08 23:22:23]

Description was changed from

==========
Revert of [Omaha] Make the whole pipeline run each time (patchset #4 id:60001 of
https://codereview.chromium.org/2665133005/ )

Reason for revert:
Causes crashes on startup in some cases.

Original issue's description:
> [Omaha] Make the whole pipeline run each time
>
> * Instead of making OmahaClient run as an IntentService that handles
individual
>   actions, run the whole pipeline, including registering new requests and
>   POSTing to the server.  This has several advantages, including that the
>   pipeline is somewhat easier to understand.
>
> * The pipeline now uses one single-shot alarm to determine when to either
>   generate a new active user request or to trigger a POST.  This requires
>   canceling existing repeating alarms.
>
> * Redoes the "isOverude" check in handleRegisterActiveRequest to just check
>   current timestamps instead of also checking that a request doesn't exist.
>   This is more logical for an "isOverdue" check, and prevents the OmahaClient
>   from trying to reschedule itself repeatedly until an existing request's
>   timestamps are screwed up.  This should be alright because the request
>   timestamp and the timestamp for the new request should match in all cases
>   where the SharedPrerences are valid.
>
> * Introduces the OmahaDelegate, which masks out calls to various classes that
>   OmahaClient requires.
>
> * Replaces all old OmahaClientTests that tested the old pipeline with one that
>   is more black-boxy and tests the new pipeline.  Significant cleanups are
still
>   required here, but the pipeline will be changing further and basic tests are
>   better than no tests.
>
> BUG=680817
>
> Review-Url: https://codereview.chromium.org/2665133005
> Cr-Commit-Position: refs/heads/master@{#448803}
> Committed:
https://chromium.googlesource.com/chromium/src/+/c9625f069b73578ab45f49be70a8...

TBR=dfalcantara@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=680817, 690054, 689850, 689894

Review-Url: https://codereview.chromium.org/2685053002
Cr-Commit-Position: refs/heads/master@{#449127}
(cherry picked from commit 0e1252cce0bae1c59bfd1c1c998f8206258b3123)
==========

to

==========
Revert of [Omaha] Make the whole pipeline run each time (patchset #4 id:60001 of
https://codereview.chromium.org/2665133005/ )

Reason for revert:
Causes crashes on startup in some cases.

Original issue's description:
> [Omaha] Make the whole pipeline run each time
>
> * Instead of making OmahaClient run as an IntentService that handles
individual
>   actions, run the whole pipeline, including registering new requests and
>   POSTing to the server.  This has several advantages, including that the
>   pipeline is somewhat easier to understand.
>
> * The pipeline now uses one single-shot alarm to determine when to either
>   generate a new active user request or to trigger a POST.  This requires
>   canceling existing repeating alarms.
>
> * Redoes the "isOverude" check in handleRegisterActiveRequest to just check
>   current timestamps instead of also checking that a request doesn't exist.
>   This is more logical for an "isOverdue" check, and prevents the OmahaClient
>   from trying to reschedule itself repeatedly until an existing request's
>   timestamps are screwed up.  This should be alright because the request
>   timestamp and the timestamp for the new request should match in all cases
>   where the SharedPrerences are valid.
>
> * Introduces the OmahaDelegate, which masks out calls to various classes that
>   OmahaClient requires.
>
> * Replaces all old OmahaClientTests that tested the old pipeline with one that
>   is more black-boxy and tests the new pipeline.  Significant cleanups are
still
>   required here, but the pipeline will be changing further and basic tests are
>   better than no tests.
>
> BUG=680817
>
> Review-Url: https://codereview.chromium.org/2665133005
> Cr-Commit-Position: refs/heads/master@{#448803}
> Committed:
https://chromium.googlesource.com/chromium/src/+/c9625f069b73578ab45f49be70a8...

TBR=dfalcantara@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=680817, 690054, 689850, 689894

Review-Url: https://codereview.chromium.org/2685053002
Cr-Commit-Position: refs/heads/master@{#449127}
(cherry picked from commit 0e1252cce0bae1c59bfd1c1c998f8206258b3123)

Review-Url: https://codereview.chromium.org/2686783003 .
Cr-Commit-Position: refs/branch-heads/3006@{#3}
Cr-Branched-From:
d6822b0656d0a9a13ca7926806e22b3afa4d2bf9-refs/heads/master@{#448862}
Committed:
https://chromium.googlesource.com/chromium/src/+/d92b8f8279b057dee4285b668ec1...
==========

[nyquist, 2017-02-08 23:22:24]

Committed patchset #1 (id:1) manually as
d92b8f8279b057dee4285b668ec1ade6d52af68e.

[nyquist, 2017-02-08 23:23:06]

nyquist@chromium.org changed reviewers:
+ amineer@chromium.org

[nyquist, 2017-02-08 23:23:06]

amineer: FYI... You told me to do this. :-)