Revert of [Omaha] Make the whole pipeline run each time

Revert of [Omaha] Make the whole pipeline run each time (patchset #4 id:60001 of https://codereview.chromium.org/2665133005/ )

Reason for revert:
Causes crashes on startup in some cases.

Original issue's description:
> [Omaha] Make the whole pipeline run each time
> 
> * Instead of making OmahaClient run as an IntentService that handles individual
>   actions, run the whole pipeline, including registering new requests and
>   POSTing to the server.  This has several advantages, including that the
>   pipeline is somewhat easier to understand.
> 
> * The pipeline now uses one single-shot alarm to determine when to either
>   generate a new active user request or to trigger a POST.  This requires
>   canceling existing repeating alarms.
> 
> * Redoes the "isOverude" check in handleRegisterActiveRequest to just check
>   current timestamps instead of also checking that a request doesn't exist.
>   This is more logical for an "isOverdue" check, and prevents the OmahaClient
>   from trying to reschedule itself repeatedly until an existing request's
>   timestamps are screwed up.  This should be alright because the request
>   timestamp and the timestamp for the new request should match in all cases
>   where the SharedPrerences are valid.
> 
> * Introduces the OmahaDelegate, which masks out calls to various classes that
>   OmahaClient requires.
> 
> * Replaces all old OmahaClientTests that tested the old pipeline with one that
>   is more black-boxy and tests the new pipeline.  Significant cleanups are still
>   required here, but the pipeline will be changing further and basic tests are
>   better than no tests.
> 
> BUG=680817
> 
> Review-Url: https://codereview.chromium.org/2665133005
> Cr-Commit-Position: refs/heads/master@{#448803}
> Committed: https://chromium.googlesource.com/chromium/src/+/c9625f069b73578ab45f49be70a830d48f6141bc

TBR=dfalcantara@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=680817, 690054, 689850, 689894
Review-Url: https://codereview.chromium.org/2685053002
Cr-Commit-Position: refs/heads/master@{#449127}
Committed: https://chromium.googlesource.com/chromium/src/+/0e1252cce0bae1c59bfd1c1c998f8206258b3123

[nyquist, 2017-02-08 23:06:12]

Created Revert of [Omaha] Make the whole pipeline run each time

[nyquist, 2017-02-08 23:06:54]

Description was changed from

==========
Revert of [Omaha] Make the whole pipeline run each time (patchset #4 id:60001 of
https://codereview.chromium.org/2665133005/ )

Reason for revert:
Causes crashes on startup in some cases.

Original issue's description:
> [Omaha] Make the whole pipeline run each time
> 
> * Instead of making OmahaClient run as an IntentService that handles
individual
>   actions, run the whole pipeline, including registering new requests and
>   POSTing to the server.  This has several advantages, including that the
>   pipeline is somewhat easier to understand.
> 
> * The pipeline now uses one single-shot alarm to determine when to either
>   generate a new active user request or to trigger a POST.  This requires
>   canceling existing repeating alarms.
> 
> * Redoes the "isOverude" check in handleRegisterActiveRequest to just check
>   current timestamps instead of also checking that a request doesn't exist.
>   This is more logical for an "isOverdue" check, and prevents the OmahaClient
>   from trying to reschedule itself repeatedly until an existing request's
>   timestamps are screwed up.  This should be alright because the request
>   timestamp and the timestamp for the new request should match in all cases
>   where the SharedPrerences are valid.
> 
> * Introduces the OmahaDelegate, which masks out calls to various classes that
>   OmahaClient requires.
> 
> * Replaces all old OmahaClientTests that tested the old pipeline with one that
>   is more black-boxy and tests the new pipeline.  Significant cleanups are
still
>   required here, but the pipeline will be changing further and basic tests are
>   better than no tests.
> 
> BUG=680817
> 
> Review-Url: https://codereview.chromium.org/2665133005
> Cr-Commit-Position: refs/heads/master@{#448803}
> Committed:
https://chromium.googlesource.com/chromium/src/+/c9625f069b73578ab45f49be70a8...

TBR=dfalcantara@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=680817
==========

to

==========
Revert of [Omaha] Make the whole pipeline run each time (patchset #4 id:60001 of
https://codereview.chromium.org/2665133005/ )

Reason for revert:
Causes crashes on startup in some cases.

Original issue's description:
> [Omaha] Make the whole pipeline run each time
> 
> * Instead of making OmahaClient run as an IntentService that handles
individual
>   actions, run the whole pipeline, including registering new requests and
>   POSTing to the server.  This has several advantages, including that the
>   pipeline is somewhat easier to understand.
> 
> * The pipeline now uses one single-shot alarm to determine when to either
>   generate a new active user request or to trigger a POST.  This requires
>   canceling existing repeating alarms.
> 
> * Redoes the "isOverude" check in handleRegisterActiveRequest to just check
>   current timestamps instead of also checking that a request doesn't exist.
>   This is more logical for an "isOverdue" check, and prevents the OmahaClient
>   from trying to reschedule itself repeatedly until an existing request's
>   timestamps are screwed up.  This should be alright because the request
>   timestamp and the timestamp for the new request should match in all cases
>   where the SharedPrerences are valid.
> 
> * Introduces the OmahaDelegate, which masks out calls to various classes that
>   OmahaClient requires.
> 
> * Replaces all old OmahaClientTests that tested the old pipeline with one that
>   is more black-boxy and tests the new pipeline.  Significant cleanups are
still
>   required here, but the pipeline will be changing further and basic tests are
>   better than no tests.
> 
> BUG=680817
> 
> Review-Url: https://codereview.chromium.org/2665133005
> Cr-Commit-Position: refs/heads/master@{#448803}
> Committed:
https://chromium.googlesource.com/chromium/src/+/c9625f069b73578ab45f49be70a8...

TBR=dfalcantara@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=680817, 690054, 689850, 689894
==========

[nyquist, 2017-02-08 23:07:08]

nyquist@chromium.org changed reviewers:
+ amineer@chromium.org

[nyquist, 2017-02-08 23:07:15]

amineer: FYI

[nyquist, 2017-02-08 23:07:29]

The CQ bit was checked by nyquist@chromium.org

[commit-bot: I haz the power, 2017-02-08 23:08:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 23:09:31]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486595249453760, "parent_rev":
"613cdf8eeeaac4830b55c4b55b4377269faa2e35", "commit_rev":
"0e1252cce0bae1c59bfd1c1c998f8206258b3123"}

[commit-bot: I haz the power, 2017-02-08 23:10:09]

Description was changed from

==========
Revert of [Omaha] Make the whole pipeline run each time (patchset #4 id:60001 of
https://codereview.chromium.org/2665133005/ )

Reason for revert:
Causes crashes on startup in some cases.

Original issue's description:
> [Omaha] Make the whole pipeline run each time
> 
> * Instead of making OmahaClient run as an IntentService that handles
individual
>   actions, run the whole pipeline, including registering new requests and
>   POSTing to the server.  This has several advantages, including that the
>   pipeline is somewhat easier to understand.
> 
> * The pipeline now uses one single-shot alarm to determine when to either
>   generate a new active user request or to trigger a POST.  This requires
>   canceling existing repeating alarms.
> 
> * Redoes the "isOverude" check in handleRegisterActiveRequest to just check
>   current timestamps instead of also checking that a request doesn't exist.
>   This is more logical for an "isOverdue" check, and prevents the OmahaClient
>   from trying to reschedule itself repeatedly until an existing request's
>   timestamps are screwed up.  This should be alright because the request
>   timestamp and the timestamp for the new request should match in all cases
>   where the SharedPrerences are valid.
> 
> * Introduces the OmahaDelegate, which masks out calls to various classes that
>   OmahaClient requires.
> 
> * Replaces all old OmahaClientTests that tested the old pipeline with one that
>   is more black-boxy and tests the new pipeline.  Significant cleanups are
still
>   required here, but the pipeline will be changing further and basic tests are
>   better than no tests.
> 
> BUG=680817
> 
> Review-Url: https://codereview.chromium.org/2665133005
> Cr-Commit-Position: refs/heads/master@{#448803}
> Committed:
https://chromium.googlesource.com/chromium/src/+/c9625f069b73578ab45f49be70a8...

TBR=dfalcantara@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=680817, 690054, 689850, 689894
==========

to

==========
Revert of [Omaha] Make the whole pipeline run each time (patchset #4 id:60001 of
https://codereview.chromium.org/2665133005/ )

Reason for revert:
Causes crashes on startup in some cases.

Original issue's description:
> [Omaha] Make the whole pipeline run each time
> 
> * Instead of making OmahaClient run as an IntentService that handles
individual
>   actions, run the whole pipeline, including registering new requests and
>   POSTing to the server.  This has several advantages, including that the
>   pipeline is somewhat easier to understand.
> 
> * The pipeline now uses one single-shot alarm to determine when to either
>   generate a new active user request or to trigger a POST.  This requires
>   canceling existing repeating alarms.
> 
> * Redoes the "isOverude" check in handleRegisterActiveRequest to just check
>   current timestamps instead of also checking that a request doesn't exist.
>   This is more logical for an "isOverdue" check, and prevents the OmahaClient
>   from trying to reschedule itself repeatedly until an existing request's
>   timestamps are screwed up.  This should be alright because the request
>   timestamp and the timestamp for the new request should match in all cases
>   where the SharedPrerences are valid.
> 
> * Introduces the OmahaDelegate, which masks out calls to various classes that
>   OmahaClient requires.
> 
> * Replaces all old OmahaClientTests that tested the old pipeline with one that
>   is more black-boxy and tests the new pipeline.  Significant cleanups are
still
>   required here, but the pipeline will be changing further and basic tests are
>   better than no tests.
> 
> BUG=680817
> 
> Review-Url: https://codereview.chromium.org/2665133005
> Cr-Commit-Position: refs/heads/master@{#448803}
> Committed:
https://chromium.googlesource.com/chromium/src/+/c9625f069b73578ab45f49be70a8...

TBR=dfalcantara@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=680817, 690054, 689850, 689894

Review-Url: https://codereview.chromium.org/2685053002
Cr-Commit-Position: refs/heads/master@{#449127}
Committed:
https://chromium.googlesource.com/chromium/src/+/0e1252cce0bae1c59bfd1c1c998f...
==========

[commit-bot: I haz the power, 2017-02-08 23:10:11]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0e1252cce0bae1c59bfd1c1c998f...