Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 2686773002: In previous implementation, if the server does the more than one server redirects, we only record t… (Closed)

Created:
3 years, 10 months ago by Jialiu Lin
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

In previous implementation, if the server does the more than one server redirects, we only record the original request url and the final url (after all server-redirects). Per Bineval team's request, this CL adds all the server redirect urls (including intermediate ones) to download pings. This is because these intermediate server redirects might be used as signal to identify certain malware/UwS campaigns. Add two histograms to count # of NavigationEvents and the memory usage. Also, fix a bug that causes duplicating IP addresses. BUG=680238 Review-Url: https://codereview.chromium.org/2644133005 Cr-Commit-Position: refs/heads/master@{#447382} (cherry picked from commit de82ac84d9c24e3910cfc4c20d81d94bfca48943) Review-Url: https://codereview.chromium.org/2686773002 . Cr-Commit-Position: refs/branch-heads/2987@{#376} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/07d6f63e7843d776ecdfc3b0ce645b0b8e080f8b

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
Jialiu Lin
3 years, 10 months ago (2017-02-08 01:48:47 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
07d6f63e7843d776ecdfc3b0ce645b0b8e080f8b.

Powered by Google App Engine
This is Rietveld 408576698