chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.h - Issue 2686773002: In previous implementation, if the server does the more than one server redirects, we only record t…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.h

Issue 2686773002: In previous implementation, if the server does the more than one server redirects, we only record t… (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc ('k') | chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.h

diff --git a/chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.h b/chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.h

index 1321c434b7b99b86fd636dcc22899fd7980b180a..f8d2910c13620de28a62139483a88f33349dcc70 100644

--- a/chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.h

+++ b/chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.h

@@ -118,6 +118,7 @@ class SafeBrowsingNavigationObserverManager

// to |out_referrer_chain|.

AttributionResult IdentifyReferrerChainForPPAPIDownload(

const GURL& initiating_frame_url,

+ const GURL& initiating_main_frame_url,

int tab_id,

bool has_user_gesture,

int user_gesture_count_limit,

@@ -198,6 +199,7 @@ class SafeBrowsingNavigationObserverManager

void AddToReferrerChain(ReferrerChain* referrer_chain,

NavigationEvent* nav_event,

+ const GURL& destination_main_frame_url,

ReferrerChainEntry::URLType type);

// Helper function to get the remaining referrer chain when we've already