Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(769)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 268673006: Fix for 10469- removal of the ArgumentDefinitionTest Ast node from the analyzer (Closed)

Created:
6 years, 7 months ago by jwren
Modified:
6 years, 7 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Fix for 10469- removal of the ArgumentDefinitionTest Ast node from the analyzer R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=35666

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : Rebase before commit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -311 lines) Patch
M editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/completion/ContextAnalyzer.java View 2 chunks +0 lines, -7 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine.services_test/src/com/google/dart/engine/services/completion/CompletionTests.java View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
D editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/ast/ArgumentDefinitionTest.java View 1 chunk +0 lines, -110 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/ast/AstVisitor.java View 1 chunk +0 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/ast/visitor/GeneralizingAstVisitor.java View 1 chunk +0 lines, -5 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/ast/visitor/RecursiveAstVisitor.java View 1 chunk +0 lines, -6 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/ast/visitor/SimpleAstVisitor.java View 1 chunk +0 lines, -5 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/ast/visitor/ToSourceVisitor.java View 1 chunk +0 lines, -7 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/ast/visitor/UnifyingAstVisitor.java View 1 chunk +0 lines, -5 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/StaticTypeAnalyzer.java View 2 chunks +0 lines, -11 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/IncrementalParseDispatcher.java View 1 chunk +0 lines, -8 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java View 1 2 chunks +4 lines, -19 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/ParserErrorCode.java View 1 chunk +0 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/ResolutionCopier.java View 1 chunk +0 lines, -12 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/utilities/ast/AstCloner.java View 1 chunk +0 lines, -5 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/utilities/ast/AstComparator.java View 1 chunk +0 lines, -7 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/utilities/ast/IncrementalAstCloner.java View 1 chunk +0 lines, -10 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/ast/AstFactory.java View 1 chunk +0 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/ast/SimpleIdentifierTest.java View 2 chunks +0 lines, -6 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/ast/visitor/ToSourceVisitorTest.java View 1 chunk +0 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/resolver/StaticTypeAnalyzerTest.java View 2 chunks +0 lines, -8 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/parser/RecoveryParserTest.java View 1 1 chunk +5 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/parser/ResolutionCopierTest.java View 3 chunks +0 lines, -16 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/parser/SimpleParserTest.java View 1 chunk +0 lines, -9 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java View 1 chunk +0 lines, -30 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/utilities/ast/AstClonerTest.java View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jwren
6 years, 7 months ago (2014-05-01 20:04:21 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/268673006/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java (right): https://codereview.chromium.org/268673006/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java#newcode5095 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java:5095: } else if (matches(TokenType.QUESTION)) { I think we ...
6 years, 7 months ago (2014-05-01 20:19:51 UTC) #2
jwren
https://codereview.chromium.org/268673006/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java (right): https://codereview.chromium.org/268673006/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java#newcode5095 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java:5095: } else if (matches(TokenType.QUESTION)) { On 2014/05/01 20:19:51, Brian ...
6 years, 7 months ago (2014-05-01 20:35:48 UTC) #3
jwren
6 years, 7 months ago (2014-05-01 22:41:46 UTC) #4
Message was sent while issue was closed. 
Committed patchset #3 manually as r35666 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698