editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/completion/ContextAnalyzer.java - Issue 268673006: Fix for 10469- removal of the ArgumentDefinitionTest Ast node from the analyzer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/completion/ContextAnalyzer.java

Issue 268673006: Fix for 10469- removal of the ArgumentDefinitionTest Ast node from the analyzer (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Rebase before commit Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | editor/tools/plugins/com.google.dart.engine.services_test/src/com/google/dart/engine/services/completion/CompletionTests.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/completion/ContextAnalyzer.java

diff --git a/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/completion/ContextAnalyzer.java b/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/completion/ContextAnalyzer.java

index 0022f7f2389d46d6db11761eec38bd9f5c023a99..7cee94ab598b18429a1584f641af6f3842ff9a49 100644

--- a/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/completion/ContextAnalyzer.java

+++ b/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/completion/ContextAnalyzer.java

@@ -1,7 +1,6 @@

package com.google.dart.engine.services.completion;

import com.google.dart.engine.ast.Annotation;

-import com.google.dart.engine.ast.ArgumentDefinitionTest;

import com.google.dart.engine.ast.ArgumentList;

import com.google.dart.engine.ast.AstNode;

import com.google.dart.engine.ast.CatchClause;

@@ -57,12 +56,6 @@ class ContextAnalyzer extends GeneralizingAstVisitor<Void> {

}

@Override

- public Void visitArgumentDefinitionTest(ArgumentDefinitionTest node) {

- state.requiresOptionalArgument();

- return super.visitArgumentDefinitionTest(node);

- }

- @Override

public Void visitCatchClause(CatchClause node) {

if (node.getExceptionType() == child) {

state.prohibitsLiterals();