editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/StaticTypeAnalyzer.java - Issue 268673006: Fix for 10469- removal of the ArgumentDefinitionTest Ast node from the analyzer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/StaticTypeAnalyzer.java

Issue 268673006: Fix for 10469- removal of the ArgumentDefinitionTest Ast node from the analyzer (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Rebase before commit Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/ast/visitor/UnifyingAstVisitor.java ('k') | editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/IncrementalParseDispatcher.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/StaticTypeAnalyzer.java

diff --git a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/StaticTypeAnalyzer.java b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/StaticTypeAnalyzer.java

index c9c0688096cbaab0f208ecfb2fcc247a69f7c1e0..a9f81b4c49e4ee5b190b720738e63ac1f639e86f 100644

--- a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/StaticTypeAnalyzer.java

+++ b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/StaticTypeAnalyzer.java

@@ -14,7 +14,6 @@

package com.google.dart.engine.internal.resolver;

import com.google.dart.engine.ast.AdjacentStrings;

-import com.google.dart.engine.ast.ArgumentDefinitionTest;

import com.google.dart.engine.ast.ArgumentList;

import com.google.dart.engine.ast.AsExpression;

import com.google.dart.engine.ast.AssignmentExpression;

@@ -243,16 +242,6 @@ public class StaticTypeAnalyzer extends SimpleAstVisitor<Void> {

}

/**

- * The Dart Language Specification, 12.33: <blockquote>The static type of an argument definition

- * test is {@code bool}.</blockquote>

- */

- @Override

- public Void visitArgumentDefinitionTest(ArgumentDefinitionTest node) {

- recordStaticType(node, typeProvider.getBoolType());

- return null;

- }

- /**

* The Dart Language Specification, 12.32: <blockquote>... the cast expression e as T ...

*

* It is a static warning if T does not denote a type available in the current lexical