Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 2686713005: Set attached flag before we call didAddScrollbar (Closed)

Created:
3 years, 10 months ago by bokan
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Set attached flag before we call didAddScrollbar This issue is caused by we call didAddScrollbar before set the attached flag. That makes FrameView::horizontalScrollbar, FrameView::verticalScrollbar always return null and ScrollableArea::setScrollbarOverlayColorTheme can not set OverlayColorTheme to ScrollbarThemeMac. In this patch we move the attached flag set before didAddScrollbar call. BUG=688516 Review-Url: https://codereview.chromium.org/2671323004 Cr-Commit-Position: refs/heads/master@{#448814} (cherry picked from commit b45a817c9a86d2d25ed6fba359abceafc728c2d3) Review-Url: https://codereview.chromium.org/2686713005 . Cr-Commit-Position: refs/branch-heads/2987@{#407} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/f8c54e0176fb6c3f9b31e5dbfcfd8d727df8d500

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/core/frame/FrameView.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
bokan
3 years, 10 months ago (2017-02-09 16:17:57 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f8c54e0176fb6c3f9b31e5dbfcfd8d727df8d500.

Powered by Google App Engine
This is Rietveld 408576698