Set attached flag before we call didAddScrollbar

Set attached flag before we call didAddScrollbar

This issue is caused by we call didAddScrollbar before set the attached flag.
That makes FrameView::horizontalScrollbar, FrameView::verticalScrollbar
always return null and ScrollableArea::setScrollbarOverlayColorTheme can not set
OverlayColorTheme to ScrollbarThemeMac.

In this patch we move the attached flag set before didAddScrollbar call.

BUG=688516
Review-Url: https://codereview.chromium.org/2671323004
Cr-Commit-Position: refs/heads/master@{#448814}
Committed: https://chromium.googlesource.com/chromium/src/+/b45a817c9a86d2d25ed6fba359abceafc728c2d3

[chaopeng, 2017-02-06 19:52:46]

The CQ bit was checked by chaopeng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 19:53:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 21:27:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 21:27:15]

Dry run: This issue passed the CQ dry run.

[chaopeng, 2017-02-06 21:39:32]

chaopeng@chromium.org changed reviewers:
+ bokan@chromium.org

[chaopeng, 2017-02-06 21:39:32]

PTAL. Thank you.

[bokan, 2017-02-07 22:22:40]

lgtm

(Talked off-line, no tests because Mac scrollbars are notoriously difficult to
test today - will add tests after fixing crbug.com/263556)

[chaopeng, 2017-02-07 22:34:30]

The CQ bit was checked by chaopeng@chromium.org

[commit-bot: I haz the power, 2017-02-07 22:35:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 00:18:31]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486506870844820, "parent_rev":
"3273e13c90a9aca77955c9a386bc66f57dded38f", "commit_rev":
"b45a817c9a86d2d25ed6fba359abceafc728c2d3"}

[commit-bot: I haz the power, 2017-02-08 00:20:09]

Description was changed from

==========
Set attached flag before we call didAddScrollbar

This issue is caused by we call didAddScrollbar before set the attached flag.
That makes FrameView::horizontalScrollbar, FrameView::verticalScrollbar
always return null and ScrollableArea::setScrollbarOverlayColorTheme can not set
OverlayColorTheme to ScrollbarThemeMac.

In this patch we move the attached flag set before didAddScrollbar call.

BUG=688516
==========

to

==========
Set attached flag before we call didAddScrollbar

This issue is caused by we call didAddScrollbar before set the attached flag.
That makes FrameView::horizontalScrollbar, FrameView::verticalScrollbar
always return null and ScrollableArea::setScrollbarOverlayColorTheme can not set
OverlayColorTheme to ScrollbarThemeMac.

In this patch we move the attached flag set before didAddScrollbar call.

BUG=688516

Review-Url: https://codereview.chromium.org/2671323004
Cr-Commit-Position: refs/heads/master@{#448814}
Committed:
https://chromium.googlesource.com/chromium/src/+/b45a817c9a86d2d25ed6fba359ab...
==========

[commit-bot: I haz the power, 2017-02-08 00:20:12]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b45a817c9a86d2d25ed6fba359ab...